Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1fd5044 authored by Vishnu Nair's avatar Vishnu Nair Committed by Automerger Merge Worker
Browse files

Merge "SF: Fix duplicate callbacks from mirrored layers" into sc-v2-dev am: f2cf7639 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/16358662

Change-Id: I56de42f07911445ad5672ecd4a10776cdc24dbcd
parents 6c63e8e3 f2cf7639

services/surfaceflinger/BufferLayer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -831,7 +831,7 @@ void BufferLayer::updateCloneBufferInfo() { 
    wp<Layer> tmpTouchableRegionCrop = mDrawingState.touchableRegionCrop;

    WindowInfo tmpInputInfo = mDrawingState.inputInfo;



    mDrawingState = clonedFrom->mDrawingState;

    cloneDrawingState(clonedFrom.get());



    mDrawingState.touchableRegionCrop = tmpTouchableRegionCrop;

    mDrawingState.zOrderRelativeOf = tmpZOrderRelativeOf;

services/surfaceflinger/BufferStateLayer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ BufferStateLayer::~BufferStateLayer() { 
    // one of the layers, in this case the original layer, needs to handle the deletion. The

    // original layer and the clone should be removed at the same time so there shouldn't be any

    // issue with the clone layer trying to use the texture.

    if (mBufferInfo.mBuffer != nullptr && !isClone()) {

    if (mBufferInfo.mBuffer != nullptr) {

        callReleaseBufferCallback(mDrawingState.releaseBufferListener,

                                  mBufferInfo.mBuffer->getBuffer(), mBufferInfo.mFrameNumber,

                                  mBufferInfo.mFence, mTransformHint,

services/surfaceflinger/Layer.cpp

+9 −3
Original line number Diff line number Diff line
@@ -2486,8 +2486,7 @@ Region Layer::getVisibleRegion(const DisplayDevice* display) const { 
}



void Layer::setInitialValuesForClone(const sp<Layer>& clonedFrom) {

    // copy drawing state from cloned layer

    mDrawingState = clonedFrom->mDrawingState;

    cloneDrawingState(clonedFrom.get());

    mClonedFrom = clonedFrom;

}
@@ -2522,7 +2521,7 @@ void Layer::updateClonedDrawingState(std::map<sp<Layer>, sp<Layer>>& clonedLayer 
    // since we may be able to pull out other children that are still alive.

    if (isClonedFromAlive()) {

        sp<Layer> clonedFrom = getClonedFrom();

        mDrawingState = clonedFrom->mDrawingState;

        cloneDrawingState(clonedFrom.get());

        clonedLayersMap.emplace(clonedFrom, this);

    }
@@ -2685,6 +2684,13 @@ bool Layer::setDropInputMode(gui::DropInputMode mode) { 
    return true;

}



void Layer::cloneDrawingState(const Layer* from) {

    mDrawingState = from->mDrawingState;

    // Skip callback info since they are not applicable for cloned layers.

    mDrawingState.releaseBufferListener = nullptr;

    mDrawingState.callbackHandles = {};

}



// ---------------------------------------------------------------------------



std::ostream& operator<<(std::ostream& stream, const Layer::FrameRate& rate) {

services/surfaceflinger/Layer.h

+1 −0
Original line number Diff line number Diff line
@@ -929,6 +929,7 @@ protected: 
    bool isClone() { return mClonedFrom != nullptr; }

    bool isClonedFromAlive() { return getClonedFrom() != nullptr; }



    void cloneDrawingState(const Layer* from);

    void updateClonedDrawingState(std::map<sp<Layer>, sp<Layer>>& clonedLayersMap);

    void updateClonedChildren(const sp<Layer>& mirrorRoot,

                              std::map<sp<Layer>, sp<Layer>>& clonedLayersMap);