Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98fabaf6 authored by Nathaniel Nifong's avatar Nathaniel Nifong
Browse files

Pass lambda to endPage callback which read back textures 

Expecting presubmit to pass after landing
https://skia-review.googlesource.com/c/skia/+/344158

Bug:skia:9765
Test: ran capture on a Pixel 3 and examined file in skia debugger

Change-Id: I3153c79fe5b98cd8cfdff928ae4940dc4a4f0b88
parent 61a682e8

libs/renderengine/skia/debug/SkiaCapture.cpp

+8 −2
Original line number Original line Diff line number Diff line
@@ -129,8 +129,14 @@ bool SkiaCapture::setupMultiFrameCapture() { 
        // SkDocuments don't take ownership of the streams they write.

        // SkDocuments don't take ownership of the streams they write.

        // we need to keep it until after mMultiPic.close()

        // we need to keep it until after mMultiPic.close()

        // procs is passed as a pointer, but just as a method of having an optional default.

        // procs is passed as a pointer, but just as a method of having an optional default.

        // procs doesn't need to outlive this Make call.

        // procs doesn't need to outlive this Make call

        mMultiPic = SkMakeMultiPictureDocument(mOpenMultiPicStream.get(), &procs);

        // The last argument is a callback for the endPage behavior.

        // See SkSharingProc.h for more explanation of this callback.

        mMultiPic = SkMakeMultiPictureDocument(

                mOpenMultiPicStream.get(), &procs,

                [sharingCtx = mSerialContext.get()](const SkPicture* pic) {

                    SkSharingSerialContext::collectNonTextureImagesFromPicture(pic, sharingCtx);

                });

        mCaptureRunning = true;

        mCaptureRunning = true;

        return true;

        return true;

    } else {

    } else {