Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 904bf99d authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix performance-for-range-copy warnings 

Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: Ib0ea650eca4b183aeaf82c9e6a44d16c80ceeef6
parent 9b82213a

libs/gui/bufferqueue/1.0/H2BGraphicBufferProducer.cpp

+3 −3
Original line number Diff line number Diff line
@@ -896,7 +896,7 @@ inline bool convertTo( 
    int const* constFds = static_cast<int const*>(baseFds.get());

    numFds = baseNumFds;

    if (l->unflatten(constBuffer, size, constFds, numFds) != NO_ERROR) {

        for (auto nhA : nhAA) {

        for (const auto& nhA : nhAA) {

            for (auto nh : nhA) {

                if (nh != nullptr) {

                    native_handle_close(nh);
@@ -907,8 +907,8 @@ inline bool convertTo( 
        return false;

    }



    for (auto nhA : nhAA) {

        for (auto nh : nhA) {

    for (const auto& nhA : nhAA) {

        for (const auto& nh : nhA) {

            if (nh != nullptr) {

                native_handle_delete(nh);

            }

services/utils/tests/PriorityDumper_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ public: 
};



static void addAll(Vector<String16>& av, const std::vector<std::string>& v) {

    for (auto element : v) {

    for (const auto& element : v) {

        av.add(String16(element.c_str()));

    }

}