Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d17c454 authored by Steven Moreland's avatar Steven Moreland
Browse files

javaObjectForIBinder: warn rets global and local 

Trying to manually delete the result of this function as a local
ref is problematic.

Bug: 227719836
Test: N/A
Change-Id: I267eaa25202fccc047aa23d1d0a45ed212e4ce10
parent ebfcecb7

libs/binder/ndk/include_ndk/android/binder_ibinder_jni.h

+6 −0
Original line number Diff line number Diff line
@@ -56,6 +56,12 @@ __attribute__((warn_unused_result)) AIBinder* AIBinder_fromJavaBinder(JNIEnv* en 
 * If the binder is null, null is returned. If this binder object was originally an IBinder object,

 * the original java object will be returned.

 *

 * WARNING: this function returns global and local references. This can be

 * figured out using GetObjectRefType. Though, when this function is called

 * from within a Java context, the local ref will automatically be cleaned

 * up. If this is called outside of a Java frame,

 * PushObjectFrame/PopObjectFrame can simulate this automatic cleanup.

 *

 * Available since API level 29.

 *

 * \param env Java environment. Must not be null.