Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b90646c authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge changes I51839f56,I821c42c3,I77ac3f77,I91afd69d 

* changes:
  binder: fix google-default-arguments
  binder: fix google-build-using-namespace
  binder: fix google-explicit-constructor
  binder: fix performance-unnecessary-value-param
parents 2d95bb9d 276781ad

libs/binder/Android.bp

+0 −4
Original line number Diff line number Diff line
@@ -181,11 +181,7 @@ cc_library { 
    ],

    tidy_checks_as_errors: [

        "*",

        "-google-build-using-namespace",

        "-google-default-arguments",

        "-google-explicit-constructor",

        "-google-runtime-int",

        "-performance-unnecessary-value-param",

    ],

}

libs/binder/IMediaResourceMonitor.cpp

+1 −0
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ IMPLEMENT_META_INTERFACE(MediaResourceMonitor, "android.media.IMediaResourceMoni 


// ----------------------------------------------------------------------



// NOLINTNEXTLINE(google-default-arguments)

status_t BnMediaResourceMonitor::onTransact( uint32_t code, const Parcel& data, Parcel* reply,

        uint32_t flags) {

    switch(code) {

libs/binder/IPCThreadState.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1077,7 +1077,7 @@ status_t IPCThreadState::writeTransactionData(int32_t cmd, uint32_t binderFlags, 


sp<BBinder> the_context_object;



void IPCThreadState::setTheContextObject(sp<BBinder> obj)

void IPCThreadState::setTheContextObject(const sp<BBinder>& obj)

{

    the_context_object = obj;

}

libs/binder/IServiceManager.cpp

+1 −1
Original line number Diff line number Diff line
@@ -310,7 +310,7 @@ sp<IBinder> ServiceManagerShim::waitForService(const String16& name16) 
    // Simple RAII object to ensure a function call immediately before going out of scope

    class Defer {

    public:

        Defer(std::function<void()>&& f) : mF(std::move(f)) {}

        explicit Defer(std::function<void()>&& f) : mF(std::move(f)) {}

        ~Defer() { mF(); }

    private:

        std::function<void()> mF;

libs/binder/IUidObserver.cpp

+1 −0
Original line number Diff line number Diff line
@@ -75,6 +75,7 @@ IMPLEMENT_META_INTERFACE(UidObserver, "android.app.IUidObserver"); 


// ----------------------------------------------------------------------



// NOLINTNEXTLINE(google-default-arguments)

status_t BnUidObserver::onTransact(

    uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags)

{