Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a77baaa authored by Mathias Agopian's avatar Mathias Agopian
Browse files

don't emit GL commands when sf is in freeze mode 

We were emitting GL commands, calling composition complete and releasing clients
without ever calling eglSwapBuffers(), which is completely wrong on non-direct
renders. This could cause transient drawing artifacts when unfreezing the
screen (upon orientaion change for instance) and could also block the clients
for ever as they are waiting for their previous buffer to be rendered.
parent 0d095244

libs/surfaceflinger/SurfaceFlinger.cpp

+1 −9
Original line number Diff line number Diff line
@@ -491,7 +491,7 @@ bool SurfaceFlinger::threadLoop() 
    handlePageFlip();



    const DisplayHardware& hw(graphicPlane(0).displayHardware());

    if (LIKELY(hw.canDraw())) {

    if (LIKELY(hw.canDraw() && !isFrozen())) {

        // repaint the framebuffer (if needed)

        handleRepaint();
@@ -512,14 +512,6 @@ bool SurfaceFlinger::threadLoop() 


void SurfaceFlinger::postFramebuffer()

{

    if (isFrozen()) {

        // we are not allowed to draw, but pause a bit to make sure

        // apps don't end up using the whole CPU, if they depend on

        // surfaceflinger for synchronization.

        usleep(8333); // 8.3ms ~ 120fps

        return;

    }



    if (!mInvalidRegion.isEmpty()) {

        const DisplayHardware& hw(graphicPlane(0).displayHardware());

        const nsecs_t now = systemTime();