Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8042c37f authored by Greg Kaiser's avatar Greg Kaiser
Browse files

dexopt: Avoid a couple std::string copies 

There are a couple places where we're taking a std::string and
then passing the result of c_str() to function taking a
const std::string reference.  This inefficiently creates a
temporary object.  We change these to directly pass the
std::string.

Test: TreeHugger
Change-Id: Ied6f13e5e2b7b71c992d325ce285fd829bdb7ee9
parent c10e80f5

cmds/installd/dexopt.cpp

+4 −4
Original line number Diff line number Diff line
@@ -1564,7 +1564,7 @@ class RunDexoptAnalyzer : public ExecVHelper { 
        if (vdex_fd >= 0) {

            AddArg(vdex_fd_arg);

        }

        AddArg(zip_fd_arg.c_str());

        AddArg(zip_fd_arg);

        if (profile_was_updated) {

            AddArg(assume_profile_changed);

        }
@@ -1572,9 +1572,9 @@ class RunDexoptAnalyzer : public ExecVHelper { 
            AddArg(downgrade_flag);

        }

        if (class_loader_context != nullptr) {

            AddArg(class_loader_context_arg.c_str());

            AddArg(class_loader_context_arg);

            if (!class_loader_context_fds.empty()) {

                AddArg(class_loader_context_fds_arg.c_str());

                AddArg(class_loader_context_fds_arg);

            }

        }
@@ -2259,7 +2259,7 @@ bool reconcile_secondary_dex_file(const std::string& dex_path, 
        drop_capabilities(uid);



        const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();

        if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,

        if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr,

                uid, storage_flag)) {

            LOG(ERROR) << "Could not validate secondary dex path " << dex_path;

            _exit(kReconcileSecondaryDexValidationError);