Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f7da38a authored by Chris Ye's avatar Chris Ye
Browse files

Mark setInputWindows of IInputFlinger interface as "oneway". 

SurfaceFlinger is the caller of this method, it uses the listener callback to ensure the
ordering when needed.
SurfaceFlinger calls this only every VSync, so overflow of binder's oneway buffer
shouldn't be a concern.

Bug: 161494456
Test: atest inputflinger_tests, atest SurfaceFlinger_test
Change-Id: I4392bb3dfec9d08b1288f1bc93ac952913c1c049
parent af1156a3

libs/input/android/os/IInputFlinger.aidl

+5 −1
Original line number Diff line number Diff line
@@ -23,7 +23,11 @@ import android.os.ISetInputWindowsListener; 
/** @hide */

interface IInputFlinger

{

    void setInputWindows(in InputWindowInfo[] inputHandles,

    // SurfaceFlinger is the caller of this method, it uses the listener callback to ensure the

    // ordering when needed.

    // SurfaceFlinger calls this only every VSync, so overflow of binder's oneway buffer

    // shouldn't be a concern.

    oneway void setInputWindows(in InputWindowInfo[] inputHandles,

            in @nullable ISetInputWindowsListener setInputWindowsListener);

    void registerInputChannel(in InputChannelInfo info);

    void unregisterInputChannel(in InputChannelInfo info);