Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ba2e7ea authored by Tomasz Wasilczyk's avatar Tomasz Wasilczyk
Browse files

Binder RPC test: check execl return status 

Also, add pragma guard to Utils.h since they are sometimes included in tests

Bug: 302723053
Test: atest binderRpcTest
Change-Id: Ic2632747375fa4847e1077d41dfa3192af68441d
parent 897ac13a

libs/binder/Utils.h

+2 −0
Original line number Diff line number Diff line
@@ -14,6 +14,8 @@ 
 * limitations under the License.

 */



#pragma once



#include <stddef.h>

#include <sys/uio.h>

#include <cstdint>

libs/binder/tests/binderRpcTest.cpp

+4 −2
Original line number Diff line number Diff line
@@ -287,8 +287,10 @@ std::unique_ptr<ProcessSession> BinderRpc::createRpcTestSocketServerProcessEtc( 


                auto writeFd = std::to_string(writeEnd.get());

                auto readFd = std::to_string(readEnd.get());

                execl(servicePath.c_str(), servicePath.c_str(), writeFd.c_str(), readFd.c_str(),

                      NULL);

                auto status = execl(servicePath.c_str(), servicePath.c_str(), writeFd.c_str(),

                                    readFd.c_str(), NULL);

                PLOGF("execl('%s', _, %s, %s) should not return at all, but it returned %d",

                      servicePath.c_str(), writeFd.c_str(), readFd.c_str(), status);

            }));



    BinderRpcTestServerConfig serverConfig;