Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 789fe918 authored by Zim's avatar Zim
Browse files

Remove unnecessary atrace event 

We have some evidence to show that the atrace_call in addEntry is
causing trace fd contention which affects binder calls like
createSurface().

Remove this atrace event as its cost doesn't outweigh its value.

Bug: 314305938
Test: Manual
Change-Id: I3d86b788656bf9dd5bc62cd78a3afbdeefd9dbff
parent 0648e7ba

services/surfaceflinger/Tracing/TransactionTracing.cpp

+0 −3
Original line number Diff line number Diff line
@@ -16,12 +16,10 @@ 


#undef LOG_TAG

#define LOG_TAG "TransactionTracing"

#define ATRACE_TAG ATRACE_TAG_GRAPHICS



#include <android-base/stringprintf.h>

#include <log/log.h>

#include <utils/SystemClock.h>

#include <utils/Trace.h>



#include "Client.h"

#include "FrontEnd/LayerCreationArgs.h"
@@ -230,7 +228,6 @@ void TransactionTracing::loop() { 


void TransactionTracing::addEntry(const std::vector<CommittedUpdates>& committedUpdates,

                                  const std::vector<uint32_t>& destroyedLayers) {

    ATRACE_CALL();

    std::scoped_lock lock(mTraceLock);

    std::vector<std::string> removedEntries;

    perfetto::protos::TransactionTraceEntry entryProto;