Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74978e1d authored by Xiang Wang's avatar Xiang Wang
Browse files

Mock init of PowerHalController in test 

We have injected a MockedPowerHalController in PowerAdvisorTest, but it
will always run init once, which will try to connect a real PowerHAL.
This was resulting in a few error logs like SELinux denials.

Bug: 280438886
Test: libsurfaceflinger_unittest
Change-Id: Icbd0289cbeba95582eed01e61dcb748e2e167c24
parent 635339c5

include/powermanager/PowerHalController.h

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ public: 
          : mHalConnector(std::move(connector)) {}

    virtual ~PowerHalController() = default;



    void init();

    virtual void init();



    virtual HalResult<void> setBoost(hardware::power::Boost boost, int32_t durationMs) override;

    virtual HalResult<void> setMode(hardware::power::Mode mode, bool enabled) override;

services/surfaceflinger/tests/unittests/mock/DisplayHardware/MockPowerHalController.h

+1 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ class MockPowerHalController : public power::PowerHalController { 
public:

    MockPowerHalController();

    ~MockPowerHalController() override;

    MOCK_METHOD(void, init, (), (override));

    MOCK_METHOD(HalResult<void>, setBoost, (Boost, int32_t), (override));

    MOCK_METHOD(HalResult<void>, setMode, (Mode, bool), (override));

    MOCK_METHOD(HalResult<sp<hardware::power::IPowerHintSession>>, createHintSession,