Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ee546d8 authored by Yiwei Zhang's avatar Yiwei Zhang
Browse files

GpuStats: migrate to new statsd native puller api (part 1) 

Bug: 148421389
Test: build, flash and boot.
Change-Id: I44f0b5befd8f879ba0542cec50212ee274ce1adb
parent c4173b5f

libs/graphicsenv/IGpuService.cpp

+0 −70
Original line number Diff line number Diff line
@@ -48,50 +48,6 @@ public: 
        remote()->transact(BnGpuService::SET_GPU_STATS, data, &reply, IBinder::FLAG_ONEWAY);

    }



    virtual status_t getGpuStatsGlobalInfo(std::vector<GpuStatsGlobalInfo>* outStats) const {

        if (!outStats) return UNEXPECTED_NULL;



        Parcel data, reply;

        status_t status;



        if ((status = data.writeInterfaceToken(IGpuService::getInterfaceDescriptor())) != OK)

            return status;



        if ((status = remote()->transact(BnGpuService::GET_GPU_STATS_GLOBAL_INFO, data, &reply)) !=

            OK)

            return status;



        int32_t result = 0;

        if ((status = reply.readInt32(&result)) != OK) return status;

        if (result != OK) return result;



        outStats->clear();

        return reply.readParcelableVector(outStats);

    }



    virtual status_t getGpuStatsAppInfo(std::vector<GpuStatsAppInfo>* outStats) const {

        if (!outStats) return UNEXPECTED_NULL;



        Parcel data, reply;

        status_t status;



        if ((status = data.writeInterfaceToken(IGpuService::getInterfaceDescriptor())) != OK) {

            return status;

        }



        if ((status = remote()->transact(BnGpuService::GET_GPU_STATS_APP_INFO, data, &reply)) !=

            OK) {

            return status;

        }



        int32_t result = 0;

        if ((status = reply.readInt32(&result)) != OK) return status;

        if (result != OK) return result;



        outStats->clear();

        return reply.readParcelableVector(outStats);

    }



    virtual void setTargetStats(const std::string& appPackageName, const uint64_t driverVersionCode,

                                const GpuStatsInfo::Stats stats, const uint64_t value) {

        Parcel data, reply;
@@ -150,32 +106,6 @@ status_t BnGpuService::onTransact(uint32_t code, const Parcel& data, Parcel* rep 


            return OK;

        }

        case GET_GPU_STATS_GLOBAL_INFO: {

            CHECK_INTERFACE(IGpuService, data, reply);



            std::vector<GpuStatsGlobalInfo> stats;

            const status_t result = getGpuStatsGlobalInfo(&stats);



            if ((status = reply->writeInt32(result)) != OK) return status;

            if (result != OK) return result;



            if ((status = reply->writeParcelableVector(stats)) != OK) return status;



            return OK;

        }

        case GET_GPU_STATS_APP_INFO: {

            CHECK_INTERFACE(IGpuService, data, reply);



            std::vector<GpuStatsAppInfo> stats;

            const status_t result = getGpuStatsAppInfo(&stats);



            if ((status = reply->writeInt32(result)) != OK) return status;

            if (result != OK) return result;



            if ((status = reply->writeParcelableVector(stats)) != OK) return status;



            return OK;

        }

        case SET_TARGET_STATS: {

            CHECK_INTERFACE(IGpuService, data, reply);

libs/graphicsenv/include/graphicsenv/IGpuService.h

+2 −11
Original line number Diff line number Diff line
@@ -16,12 +16,11 @@ 


#pragma once



#include <vector>



#include <binder/IInterface.h>

#include <cutils/compiler.h>

#include <graphicsenv/GpuStatsInfo.h>

#include <graphicsenv/GraphicsEnv.h>



#include <vector>



namespace android {
@@ -43,20 +42,12 @@ public: 
    // set target stats.

    virtual void setTargetStats(const std::string& appPackageName, const uint64_t driverVersionCode,

                                const GpuStatsInfo::Stats stats, const uint64_t value = 0) = 0;



    // get GPU global stats from GpuStats module.

    virtual status_t getGpuStatsGlobalInfo(std::vector<GpuStatsGlobalInfo>* outStats) const = 0;



    // get GPU app stats from GpuStats module.

    virtual status_t getGpuStatsAppInfo(std::vector<GpuStatsAppInfo>* outStats) const = 0;

};



class BnGpuService : public BnInterface<IGpuService> {

public:

    enum IGpuServiceTag {

        SET_GPU_STATS = IBinder::FIRST_CALL_TRANSACTION,

        GET_GPU_STATS_GLOBAL_INFO,

        GET_GPU_STATS_APP_INFO,

        SET_TARGET_STATS,

        // Always append new enum to the end.

    };

services/gpuservice/GpuService.cpp

+0 −10
Original line number Diff line number Diff line
@@ -57,16 +57,6 @@ void GpuService::setGpuStats(const std::string& driverPackageName, 
                                 isDriverLoaded, driverLoadingTime);

}



status_t GpuService::getGpuStatsGlobalInfo(std::vector<GpuStatsGlobalInfo>* outStats) const {

    mGpuStats->pullGlobalStats(outStats);

    return OK;

}



status_t GpuService::getGpuStatsAppInfo(std::vector<GpuStatsAppInfo>* outStats) const {

    mGpuStats->pullAppStats(outStats);

    return OK;

}



void GpuService::setTargetStats(const std::string& appPackageName, const uint64_t driverVersionCode,

                                const GpuStatsInfo::Stats stats, const uint64_t value) {

    mGpuStats->insertTargetStats(appPackageName, driverVersionCode, stats, value);

services/gpuservice/GpuService.h

+0 −2
Original line number Diff line number Diff line
@@ -59,8 +59,6 @@ private: 
                     const std::string& appPackageName, const int32_t vulkanVersion,

                     GpuStatsInfo::Driver driver, bool isDriverLoaded,

                     int64_t driverLoadingTime) override;

    status_t getGpuStatsGlobalInfo(std::vector<GpuStatsGlobalInfo>* outStats) const override;

    status_t getGpuStatsAppInfo(std::vector<GpuStatsAppInfo>* outStats) const override;

    void setTargetStats(const std::string& appPackageName, const uint64_t driverVersionCode,

                        const GpuStatsInfo::Stats stats, const uint64_t value) override;

services/gpuservice/gpustats/GpuStats.cpp

+0 −30
Original line number Diff line number Diff line
@@ -233,34 +233,4 @@ void GpuStats::dumpAppLocked(std::string* result) { 
    }

}



void GpuStats::pullGlobalStats(std::vector<GpuStatsGlobalInfo>* outStats) {

    ATRACE_CALL();



    std::lock_guard<std::mutex> lock(mLock);

    outStats->clear();

    outStats->reserve(mGlobalStats.size());



    interceptSystemDriverStatsLocked();



    for (const auto& ele : mGlobalStats) {

        outStats->emplace_back(ele.second);

    }



    mGlobalStats.clear();

}



void GpuStats::pullAppStats(std::vector<GpuStatsAppInfo>* outStats) {

    ATRACE_CALL();



    std::lock_guard<std::mutex> lock(mLock);

    outStats->clear();

    outStats->reserve(mAppStats.size());



    for (const auto& ele : mAppStats) {

        outStats->emplace_back(ele.second);

    }



    mAppStats.clear();

}



} // namespace android