Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67753c38 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: RPC checks for appendParcel 

It would be unstable to append a parcel of one format to a format of
another.

Bug: 182938972
Bug: 182939048
Test: binderRpcTest
Change-Id: Ief93c3f02398094f8a1d0ec1550836c53ac13ec7
parent 5e7768d7

libs/binder/Parcel.cpp

+5 −0
Original line number Diff line number Diff line
@@ -418,6 +418,11 @@ status_t Parcel::setData(const uint8_t* buffer, size_t len) 


status_t Parcel::appendFrom(const Parcel *parcel, size_t offset, size_t len)

{

    if (parcel->isForRpc() != isForRpc()) {

        ALOGE("Cannot append Parcel of one format to another.");

        return BAD_TYPE;

    }



    status_t err;

    const uint8_t *data = parcel->mData;

    const binder_size_t *objects = parcel->mObjects;

libs/binder/tests/binderRpcTest.cpp

+13 −0
Original line number Diff line number Diff line
@@ -406,6 +406,19 @@ TEST_P(BinderRpc, TransactionsMustBeMarkedRpc) { 
    EXPECT_EQ(BAD_TYPE, proc.rootBinder->transact(IBinder::PING_TRANSACTION, data, &reply, 0));

}



TEST_P(BinderRpc, AppendSeparateFormats) {

    auto proc = createRpcTestSocketServerProcess(1);



    Parcel p1;

    p1.markForBinder(proc.rootBinder);

    p1.writeInt32(3);



    Parcel p2;



    EXPECT_EQ(BAD_TYPE, p1.appendFrom(&p2, 0, p2.dataSize()));

    EXPECT_EQ(BAD_TYPE, p2.appendFrom(&p1, 0, p1.dataSize()));

}



TEST_P(BinderRpc, UnknownTransaction) {

    auto proc = createRpcTestSocketServerProcess(1);

    Parcel data;