Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 64f45cf2 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "[SurfaceFlinger] Update comments to clarify transform."

parents b71253ec 74861ad4
Loading
Loading
Loading
Loading
+3 −2
Original line number Diff line number Diff line
@@ -2446,6 +2446,7 @@ InputWindowInfo Layer::fillInputInfo() {
        ySurfaceInset = std::round(ySurfaceInset * yScale);
    }

    // Transform the layer bounds from layer coordinate space to display coordinate space.
    Rect transformedLayerBounds = t.transform(layerBounds);

    // clamp inset to layer bounds
@@ -2470,7 +2471,7 @@ InputWindowInfo Layer::fillInputInfo() {
        transformedLayerBounds.bottom = tmp;
    }

    // Input coordinate should match the layer bounds.
    // Input coordinates should be in display coordinate space.
    info.frameLeft = transformedLayerBounds.left;
    info.frameTop = transformedLayerBounds.top;
    info.frameRight = transformedLayerBounds.right;
@@ -2483,7 +2484,7 @@ InputWindowInfo Layer::fillInputInfo() {
    // the final frame calculated.
    // 1. Take the original transform set on the window and get the inverse transform. This is
    //    used to get the final bounds in display space (ignorning the transform). Apply the
    //    inverse transform on the layerBounds to get the untransformed frame (in display space)
    //    inverse transform on the layerBounds to get the untransformed frame (in layer space)
    // 2. Take the top and left of the untransformed frame to get the real position on screen.
    //    Apply the layer transform on top/left so it includes any scale or rotation. These will
    //    be the new translation values for the transform.
+2 −1
Original line number Diff line number Diff line
@@ -1073,7 +1073,8 @@ private:
    sp<Layer> getRootLayer();

    // Cached properties computed from drawing state
    // Effective transform taking into account parent transforms and any parent scaling.
    // Effective transform taking into account parent transforms and any parent scaling, which is
    // a transform from the current layer coordinate space to display(screen) coordinate space.
    ui::Transform mEffectiveTransform;

    // Bounds of the layer before any transformation is applied and before it has been cropped