Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5764fc1c authored by Vova Sharaienko's avatar Vova Sharaienko
Browse files

StatsAIDL: eliminated extra reverseDomainName string copy creation 

Bug: 212755214
Test: aidl_stats_client
Change-Id: I93c434115c75134ed1494b521df8a209e58e2dfe
parent 13ba5335

services/stats/StatsAidl.cpp

+3 −3
Original line number Diff line number Diff line
@@ -30,14 +30,14 @@ namespace stats { 
StatsHal::StatsHal() {}



ndk::ScopedAStatus StatsHal::reportVendorAtom(const VendorAtom& vendorAtom) {

    std::string reverseDomainName = (std::string) vendorAtom.reverseDomainName;

    if (vendorAtom.atomId < 100000 || vendorAtom.atomId >= 200000) {

        ALOGE("Atom ID %ld is not a valid vendor atom ID", (long) vendorAtom.atomId);

        return ndk::ScopedAStatus::fromServiceSpecificErrorWithMessage(

            -1, "Not a valid vendor atom ID");

    }

    if (reverseDomainName.length() > 50) {

        ALOGE("Vendor atom reverse domain name %s is too long.", reverseDomainName.c_str());

    if (vendorAtom.reverseDomainName.length() > 50) {

        ALOGE("Vendor atom reverse domain name %s is too long.",

            vendorAtom.reverseDomainName.c_str());

        return ndk::ScopedAStatus::fromServiceSpecificErrorWithMessage(

            -1, "Vendor atom reverse domain name is too long");

    }