Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 568dbe78 authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

EventHub: Enforce that absolute axis values are within reported range 

Crash when an absolute axis value that is outside its reported range
is sent from the kernel. This will help us identify cases where drivers
are reporting events that do not conform to the evdev interface.

Bug: 293156873
Test: presubmit
Change-Id: I5080a031866f0dd7dabf06a20d75c52954303ae5
parent 69b92500

services/inputflinger/reader/EventHub.cpp

+17 −0
Original line number Diff line number Diff line
@@ -456,6 +456,16 @@ static std::unordered_map<int32_t /*lightId*/, RawLightInfo> readLightsConfigura 
    return lightInfos;

}



static bool isValidEvAbsValue(int32_t code, int32_t value, const RawAbsoluteAxisInfo& info) {

    if (code == ABS_MT_TRACKING_ID && value == -1) {

        return true;

    }

    if (value >= info.minValue && value <= info.maxValue) {

        return true;

    }

    return false;

}



// --- Global Functions ---



ftl::Flags<InputDeviceClass> getAbsAxisUsage(int32_t axis,
@@ -804,6 +814,13 @@ void EventHub::Device::trackInputEvent(const struct input_event& event) { 
                                InputEventLookup::getLinuxEvdevLabel(EV_ABS, event.code, 0)

                                        .code.c_str(),

                                event.value);

            LOG_ALWAYS_FATAL_IF(!isValidEvAbsValue(event.code, event.value, it->second.info),

                                "%s: device '%s' received invalid value %d for EV_ABS code %s with "

                                "range [%d, %d]",

                                __func__, identifier.name.c_str(), event.value,

                                InputEventLookup::getLinuxEvdevLabel(EV_ABS, event.code, 0)

                                        .code.c_str(),

                                it->second.info.minValue, it->second.info.maxValue);

            it->second.value = event.value;

            break;

        }