Merge "[sf] recover when layer snapshot is null" into main

    constexpr bool kCursorOnly = false;

    const auto layers = moveSnapshotsToCompositionArgs(refreshArgs, kCursorOnly);

    if (mLayerLifecycleManagerEnabled && !refreshArgs.updatingGeometryThisFrame) {

    if (mLayerLifecycleManagerEnabled && !mVisibleRegionsDirty) {

        for (const auto& [token, display] : FTL_FAKE_GUARD(mStateLock, mDisplays)) {

            auto compositionDisplay = display->getCompositionDisplay();

            if (!compositionDisplay->getState().isEnabled) continue;

            for (auto outputLayer : compositionDisplay->getOutputLayersOrderedByZ()) {

                LLOG_ALWAYS_FATAL_WITH_TRACE_IF(outputLayer->getLayerFE().getCompositionState() ==

                                                        nullptr,

                                                "Output layer %s for display %s %" PRIu64

                                                " has a null "

                                                "snapshot.",

                if (outputLayer->getLayerFE().getCompositionState() == nullptr) {

                    // This is unexpected but instead of crashing, capture traces to disk

                    // and recover gracefully by forcing CE to rebuild layer stack.

                    ALOGE("Output layer %s for display %s %" PRIu64 " has a null "

                          "snapshot. Forcing mVisibleRegionsDirty",

                          outputLayer->getLayerFE().getDebugName(),

                                                compositionDisplay->getName().c_str(),

                                                compositionDisplay->getId().value);

                          compositionDisplay->getName().c_str(), compositionDisplay->getId().value);

                    TransactionTraceWriter::getInstance().invoke(__func__, /* overwrite= */ false);

                    mVisibleRegionsDirty = true;

                    refreshArgs.updatingOutputGeometryThisFrame = mVisibleRegionsDirty;

                    refreshArgs.updatingGeometryThisFrame = mVisibleRegionsDirty;

                }

            }

        }

    }