Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45bb088d authored by Siarhei Vishniakou's avatar Siarhei Vishniakou
Browse files

Remove unused variables from InputClassifier 

The variables remained from a different implementation. They are not
used by the code.
Also, add an "override" keyword in some places.

Bug: 117935272
Test: presubmit only
Change-Id: Id4edf2d2658287247a01567c126305e07d407df2
parent 8a0222e6

services/inputflinger/InputClassifier.h

+6 −14
Original line number Original line Diff line number Diff line
@@ -162,15 +162,6 @@ private: 
    std::unordered_map<int32_t /*deviceId*/, nsecs_t /*downTime*/>

    std::unordered_map<int32_t /*deviceId*/, nsecs_t /*downTime*/>

            mLastDownTimes; //GUARDED_BY(mLock);

            mLastDownTimes; //GUARDED_BY(mLock);

    void updateLastDownTime(int32_t deviceId, nsecs_t downTime);

    void updateLastDownTime(int32_t deviceId, nsecs_t downTime);

    // Should only be accessed through isResetNeeded() and setResetNeeded()

    bool mResetNeeded = false; //GUARDED_BY(mLock);

    /**

     * Check whether reset should be performed. Reset should be performed

     * if the eventTime of the current event is older than mLastDownTime,

     * i.e. a new gesture has already begun, but an older gesture is still being processed.

     */

    bool isResetNeeded(nsecs_t eventTime);

    void setResetNeeded(bool isNeeded);





    /**

    /**

     * Exit the InputClassifier HAL thread.

     * Exit the InputClassifier HAL thread.
@@ -188,11 +179,12 @@ private: 
class InputClassifier : public InputClassifierInterface {

class InputClassifier : public InputClassifierInterface {

public:

public:

    explicit InputClassifier(const sp<InputListenerInterface>& listener);

    explicit InputClassifier(const sp<InputListenerInterface>& listener);

    virtual void notifyConfigurationChanged(const NotifyConfigurationChangedArgs* args);



    virtual void notifyKey(const NotifyKeyArgs* args);

    virtual void notifyConfigurationChanged(const NotifyConfigurationChangedArgs* args) override;

    virtual void notifyMotion(const NotifyMotionArgs* args);

    virtual void notifyKey(const NotifyKeyArgs* args) override;

    virtual void notifySwitch(const NotifySwitchArgs* args);

    virtual void notifyMotion(const NotifyMotionArgs* args) override;

    virtual void notifyDeviceReset(const NotifyDeviceResetArgs* args);

    virtual void notifySwitch(const NotifySwitchArgs* args) override;

    virtual void notifyDeviceReset(const NotifyDeviceResetArgs* args) override;





private:

private:

    std::unique_ptr<MotionClassifierInterface> mMotionClassifier = nullptr;

    std::unique_ptr<MotionClassifierInterface> mMotionClassifier = nullptr;