Commit 457296ad authored Sep 04, 2014 by Stephen Hines Committed by Rom Lemarchand Sep 04, 2014

Fix undefined behavior (not returning a value from a function with return).

Bug: 17379740

This function was missing a return statement, even though it declares a return
type. This is undefined behavior, which clang miscompiled into just falling
through to a later function in some cases. Adding the return statement
fixes the undefined behavior (and probably fixes a bug too).

Change-Id: I05c03b6473b831769dc4fa8b5ba43fb4249f7626

parent 98e56d92

include/ui/mat4.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -322,6 +322,7 @@ tmat44<T> tmat44<T>::rotate(A radian, const tvec3<B>& about) {
		r[ 1] = xync + zs; r[ 5] = yync + c; r[ 9] = yznc - xs;
		r[ 2] = zxnc - ys; r[ 6] = yznc + xs; r[10] = zznc + c;
		}
		return rotation;
		}

		// ----------------------------------------------------------------------------------------