Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43065bde authored by Ady Abraham's avatar Ady Abraham
Browse files

SF: pass expectedPresentTime to composer 

Bug: 198186194
Test: VTS
Change-Id: I1265f4f016fc83a9e730c1eb6a00532c968b0a79
parent 8a0beeba

services/surfaceflinger/CompositionEngine/include/compositionengine/CompositionRefreshArgs.h

+3 −0
Original line number Diff line number Diff line
@@ -85,6 +85,9 @@ struct CompositionRefreshArgs { 
    // to prevent an early presentation of a frame.

    std::shared_ptr<FenceTime> previousPresentFence;



    // The expected time for the next present

    nsecs_t expectedPresentTime{0};



    // If set, a frame has been scheduled for that time.

    std::optional<std::chrono::steady_clock::time_point> scheduledFrameTime;

};

services/surfaceflinger/CompositionEngine/include/compositionengine/impl/OutputCompositionState.h

+3 −0
Original line number Diff line number Diff line
@@ -121,6 +121,9 @@ struct OutputCompositionState { 
    // to prevent an early presentation of a frame.

    std::shared_ptr<FenceTime> previousPresentFence;



    // The expected time for the next present

    nsecs_t expectedPresentTime{0};



    // Current display brightness

    float displayBrightnessNits{-1.f};

services/surfaceflinger/CompositionEngine/src/Display.cpp

+2 −1
Original line number Diff line number Diff line
@@ -227,7 +227,8 @@ void Display::chooseCompositionStrategy() { 
    if (status_t result =

                hwc.getDeviceCompositionChanges(*halDisplayId, anyLayersRequireClientComposition(),

                                                getState().earliestPresentTime,

                                                getState().previousPresentFence, &changes);

                                                getState().previousPresentFence,

                                                getState().expectedPresentTime, &changes);

        result != NO_ERROR) {

        ALOGE("chooseCompositionStrategy failed for %s: %d (%s)", getName().c_str(), result,

              strerror(-result));

services/surfaceflinger/CompositionEngine/src/Output.cpp

+1 −0
Original line number Diff line number Diff line
@@ -728,6 +728,7 @@ void Output::writeCompositionState(const compositionengine::CompositionRefreshAr 


    editState().earliestPresentTime = refreshArgs.earliestPresentTime;

    editState().previousPresentFence = refreshArgs.previousPresentFence;

    editState().expectedPresentTime = refreshArgs.expectedPresentTime;



    compositionengine::OutputLayer* peekThroughLayer = nullptr;

    sp<GraphicBuffer> previousOverride = nullptr;

services/surfaceflinger/CompositionEngine/tests/DisplayTest.cpp

+4 −4
Original line number Diff line number Diff line
@@ -560,7 +560,7 @@ TEST_F(DisplayChooseCompositionStrategyTest, takesEarlyOutIfGpuDisplay) { 
TEST_F(DisplayChooseCompositionStrategyTest, takesEarlyOutOnHwcError) {

    EXPECT_CALL(*mDisplay, anyLayersRequireClientComposition()).WillOnce(Return(false));

    EXPECT_CALL(mHwComposer,

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), false, _, _, _))

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), false, _, _, _, _))

            .WillOnce(Return(INVALID_OPERATION));



    mDisplay->chooseCompositionStrategy();
@@ -583,7 +583,7 @@ TEST_F(DisplayChooseCompositionStrategyTest, normalOperation) { 
            .WillOnce(Return(false));



    EXPECT_CALL(mHwComposer,

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), true, _, _, _))

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), true, _, _, _, _))

            .WillOnce(Return(NO_ERROR));

    EXPECT_CALL(*mDisplay, allLayersRequireClientComposition()).WillOnce(Return(false));
@@ -615,8 +615,8 @@ TEST_F(DisplayChooseCompositionStrategyTest, normalOperationWithChanges) { 
            .WillOnce(Return(false));



    EXPECT_CALL(mHwComposer,

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), true, _, _, _))

            .WillOnce(DoAll(SetArgPointee<4>(changes), Return(NO_ERROR)));

                getDeviceCompositionChanges(HalDisplayId(DEFAULT_DISPLAY_ID), true, _, _, _, _))

            .WillOnce(DoAll(SetArgPointee<5>(changes), Return(NO_ERROR)));

    EXPECT_CALL(*mDisplay, applyChangedTypesToLayers(changes.changedTypes)).Times(1);

    EXPECT_CALL(*mDisplay, applyDisplayRequests(changes.displayRequests)).Times(1);

    EXPECT_CALL(*mDisplay, applyLayerRequestsToLayers(changes.layerRequests)).Times(1);