Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ef1b76f authored by Ady Abraham's avatar Ady Abraham
Browse files

GLESRenderEngine: validate eglQueryStringImplementationANDROID for nullptr 

Log fatal the EGL error in case eglQueryStringImplementationANDROID
returns nullptr;

Bug: 155272618
Test: boot
Change-Id: I4be7f798adfa7fdd7378dc509c847299f0539c7f
parent 1b8793a6

libs/renderengine/gl/GLESRenderEngine.cpp

+13 −2
Original line number Diff line number Diff line
@@ -208,9 +208,20 @@ std::unique_ptr<GLESRenderEngine> GLESRenderEngine::create(const RenderEngineCre 
        LOG_ALWAYS_FATAL("failed to initialize EGL");

    }



    const auto eglVersion = eglQueryStringImplementationANDROID(display, EGL_VERSION);

    if (!eglVersion) {

        checkGlError(__FUNCTION__, __LINE__);

        LOG_ALWAYS_FATAL("eglQueryStringImplementationANDROID(EGL_VERSION) failed");

    }



    const auto eglExtensions = eglQueryStringImplementationANDROID(display, EGL_EXTENSIONS);

    if (!eglExtensions) {

        checkGlError(__FUNCTION__, __LINE__);

        LOG_ALWAYS_FATAL("eglQueryStringImplementationANDROID(EGL_EXTENSIONS) failed");

    }



    GLExtensions& extensions = GLExtensions::getInstance();

    extensions.initWithEGLStrings(eglQueryStringImplementationANDROID(display, EGL_VERSION),

                                  eglQueryStringImplementationANDROID(display, EGL_EXTENSIONS));

    extensions.initWithEGLStrings(eglVersion, eglExtensions);



    // The code assumes that ES2 or later is available if this extension is

    // supported.