Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d6136d0 authored by George Burgess IV's avatar George Burgess IV Committed by android-build-merger
Browse files

Merge "LayerStats: Fix a use-after-free"

am: e8014771

Change-Id: Id359884a4de3df80abbe40eaaed786fae9d31d6a
parents 69a88f73 e8014771
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ void LayerStats::traverseLayerTreeStatsLocked(
        base::StringAppendF(&key, ",%s", layerCompositionType(layer->hwcCompositionType));
        base::StringAppendF(&key, ",%d", layer->isProtected);
        base::StringAppendF(&key, ",%s", layerTransform(layer->hwcTransform));
        base::StringAppendF(&key, ",%s", layerPixelFormat(layer->activeBuffer.format));
        base::StringAppendF(&key, ",%s", layerPixelFormat(layer->activeBuffer.format).c_str());
        base::StringAppendF(&key, ",%s", layer->dataspace.c_str());
        base::StringAppendF(&key, ",%s",
                            destinationLocation(layer->hwcFrame.left, layerGlobal.resolution[0],
@@ -162,8 +162,8 @@ const char* LayerStats::layerCompositionType(int32_t compositionType) {
    return getCompositionName(static_cast<hwc2_composition_t>(compositionType));
}

const char* LayerStats::layerPixelFormat(int32_t pixelFormat) {
    return decodePixelFormat(pixelFormat).c_str();
std::string LayerStats::layerPixelFormat(int32_t pixelFormat) {
    return decodePixelFormat(pixelFormat);
}

std::string LayerStats::scaleRatioWH(const LayerProtoParser::Layer* layer) {
+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ private:
    // Return the name of the composition type
    static const char* layerCompositionType(int32_t compositionType);
    // Return the name of the pixel format
    static const char* layerPixelFormat(int32_t pixelFormat);
    static std::string layerPixelFormat(int32_t pixelFormat);
    // Calculate scale ratios of layer's width/height with rotation information
    static std::string scaleRatioWH(const LayerProtoParser::Layer* layer);
    // Calculate scale ratio from source to destination and convert to string