Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37c2c9b2 authored by Lloyd Pique's avatar Lloyd Pique
Browse files

SF: Introduce OutputLayerCompositionState 

This moves the display-dependent state from LayerBE.h to a new
OutputLayerCompositionState.h header, adds some simple accessors to
get the new state, and minimally adjusts the existing SurfaceFlinger
code to use the new structure.

Test: atest libsurfaceflinger_unittest libcompositionengine_test
Bug: 121291683
Change-Id: I00370f05dc6b2a3db34094862c46084e7575dbda
parent 564287c3

services/surfaceflinger/BufferLayer.cpp

+34 −16
Original line number Diff line number Diff line
@@ -24,8 +24,11 @@ 
#include <mutex>



#include <compositionengine/CompositionEngine.h>

#include <compositionengine/Display.h>

#include <compositionengine/Layer.h>

#include <compositionengine/LayerCreationArgs.h>

#include <compositionengine/OutputLayer.h>

#include <compositionengine/impl/OutputLayerCompositionState.h>

#include <cutils/compiler.h>

#include <cutils/native_handle.h>

#include <cutils/properties.h>
@@ -66,11 +69,10 @@ BufferLayer::BufferLayer(const LayerCreationArgs& args) 
BufferLayer::~BufferLayer() {

    mFlinger->deleteTextureAsync(mTextureName);



    if (!getBE().mHwcLayers.empty()) {

    if (destroyAllHwcLayersPlusChildren()) {

        ALOGE("Found stale hardware composer layers when destroying "

              "surface flinger layer %s",

              mName.string());

        destroyAllHwcLayersPlusChildren();

    }



    mFlinger->mTimeStats->onDestroy(getSequence());
@@ -171,7 +173,8 @@ bool BufferLayer::prepareClientLayer(const RenderArea& renderArea, const Region& 
        layer.source.buffer.usePremultipliedAlpha = getPremultipledAlpha();

        layer.source.buffer.isY410BT2020 = isHdrY410();

        // TODO: we could be more subtle with isFixedSize()

        const bool useFiltering = needsFiltering() || renderArea.needsFiltering() || isFixedSize();

        const bool useFiltering = needsFiltering(renderArea.getDisplayDevice()) ||

                renderArea.needsFiltering() || isFixedSize();



        // Query the texture matrix given our current filtering mode.

        float textureMatrix[16];
@@ -240,23 +243,26 @@ bool BufferLayer::isHdrY410() const { 
            getBE().compositionInfo.mBuffer->getPixelFormat() == HAL_PIXEL_FORMAT_RGBA_1010102);

}



void BufferLayer::setPerFrameData(DisplayId displayId, const ui::Transform& transform,

                                  const Rect& viewport, int32_t supportedPerFrameMetadata) {

    RETURN_IF_NO_HWC_LAYER(displayId);

void BufferLayer::setPerFrameData(const sp<const DisplayDevice>& displayDevice,

                                  const ui::Transform& transform, const Rect& viewport,

                                  int32_t supportedPerFrameMetadata) {

    RETURN_IF_NO_HWC_LAYER(displayDevice);



    // Apply this display's projection's viewport to the visible region

    // before giving it to the HWC HAL.

    Region visible = transform.transform(visibleRegion.intersect(viewport));



    auto& hwcInfo = getBE().mHwcLayers[displayId];

    auto& hwcLayer = hwcInfo.layer;

    const auto outputLayer = findOutputLayerForDisplay(displayDevice);

    LOG_FATAL_IF(!outputLayer || !outputLayer->getState().hwc);



    auto& hwcLayer = (*outputLayer->getState().hwc).hwcLayer;

    auto error = hwcLayer->setVisibleRegion(visible);

    if (error != HWC2::Error::None) {

        ALOGE("[%s] Failed to set visible region: %s (%d)", mName.string(),

              to_string(error).c_str(), static_cast<int32_t>(error));

        visible.dump(LOG_TAG);

    }

    getBE().compositionInfo.hwc.visibleRegion = visible;

    outputLayer->editState().visibleRegion = visible;



    error = hwcLayer->setSurfaceDamage(surfaceDamageRegion);

    if (error != HWC2::Error::None) {
@@ -268,7 +274,7 @@ void BufferLayer::setPerFrameData(DisplayId displayId, const ui::Transform& tran 


    // Sideband layers

    if (getBE().compositionInfo.hwc.sidebandStream.get()) {

        setCompositionType(displayId, HWC2::Composition::Sideband);

        setCompositionType(displayDevice, Hwc2::IComposerClient::Composition::SIDEBAND);

        ALOGV("[%s] Requesting Sideband composition", mName.string());

        error = hwcLayer->setSidebandStream(getBE().compositionInfo.hwc.sidebandStream->handle());

        if (error != HWC2::Error::None) {
@@ -283,10 +289,10 @@ void BufferLayer::setPerFrameData(DisplayId displayId, const ui::Transform& tran 
    // Device or Cursor layers

    if (mPotentialCursor) {

        ALOGV("[%s] Requesting Cursor composition", mName.string());

        setCompositionType(displayId, HWC2::Composition::Cursor);

        setCompositionType(displayDevice, Hwc2::IComposerClient::Composition::CURSOR);

    } else {

        ALOGV("[%s] Requesting Device composition", mName.string());

        setCompositionType(displayId, HWC2::Composition::Device);

        setCompositionType(displayDevice, Hwc2::IComposerClient::Composition::DEVICE);

    }



    ALOGV("setPerFrameData: dataspace = %d", mCurrentDataSpace);
@@ -313,7 +319,7 @@ void BufferLayer::setPerFrameData(DisplayId displayId, const ui::Transform& tran 
    getBE().compositionInfo.hwc.supportedPerFrameMetadata = supportedPerFrameMetadata;

    getBE().compositionInfo.hwc.colorTransform = getColorTransform();



    setHwcLayerBuffer(displayId);

    setHwcLayerBuffer(displayDevice);

}



bool BufferLayer::onPreComposition(nsecs_t refreshStartTime) {
@@ -605,9 +611,21 @@ bool BufferLayer::getOpacityForFormat(uint32_t format) { 
    return true;

}



bool BufferLayer::needsFiltering() const {

    const auto displayFrame = getBE().compositionInfo.hwc.displayFrame;

    const auto sourceCrop = getBE().compositionInfo.hwc.sourceCrop;

bool BufferLayer::needsFiltering(const sp<const DisplayDevice>& displayDevice) const {

    // If we are not capturing based on the state of a known display device, we

    // only return mNeedsFiltering

    if (displayDevice == nullptr) {

        return mNeedsFiltering;

    }



    const auto outputLayer = findOutputLayerForDisplay(displayDevice);

    if (outputLayer == nullptr) {

        return mNeedsFiltering;

    }



    const auto& compositionState = outputLayer->getState();

    const auto displayFrame = compositionState.displayFrame;

    const auto sourceCrop = compositionState.sourceCrop;

    return mNeedsFiltering || sourceCrop.getHeight() != displayFrame.getHeight() ||

            sourceCrop.getWidth() != displayFrame.getWidth();

}

services/surfaceflinger/BufferLayer.h

+4 −4
Original line number Diff line number Diff line
@@ -80,8 +80,8 @@ public: 


    bool isHdrY410() const override;



    void setPerFrameData(DisplayId displayId, const ui::Transform& transform, const Rect& viewport,

                         int32_t supportedPerFrameMetadata) override;

    void setPerFrameData(const sp<const DisplayDevice>& display, const ui::Transform& transform,

                         const Rect& viewport, int32_t supportedPerFrameMetadata) override;



    bool onPreComposition(nsecs_t refreshStartTime) override;

    bool onPostComposition(const std::optional<DisplayId>& displayId,
@@ -148,7 +148,7 @@ private: 
    virtual status_t updateActiveBuffer() = 0;

    virtual status_t updateFrameNumber(nsecs_t latchTime) = 0;



    virtual void setHwcLayerBuffer(DisplayId displayId) = 0;

    virtual void setHwcLayerBuffer(const sp<const DisplayDevice>& displayDevice) = 0;



protected:

    // Loads the corresponding system property once per process
@@ -177,7 +177,7 @@ protected: 


private:

    // Returns true if this layer requires filtering

    bool needsFiltering() const;

    bool needsFiltering(const sp<const DisplayDevice>& displayDevice) const;



    uint64_t getHeadFrameNumber() const;

services/surfaceflinger/BufferQueueLayer.cpp

+12 −6
Original line number Diff line number Diff line
@@ -14,13 +14,16 @@ 
 * limitations under the License.

 */



#include <compositionengine/Display.h>

#include <compositionengine/OutputLayer.h>

#include <compositionengine/impl/OutputLayerCompositionState.h>

#include <system/window.h>



#include "BufferQueueLayer.h"

#include "LayerRejecter.h"



#include "TimeStats/TimeStats.h"



#include <system/window.h>



namespace android {



BufferQueueLayer::BufferQueueLayer(const LayerCreationArgs& args) : BufferLayer(args) {}
@@ -350,13 +353,16 @@ status_t BufferQueueLayer::updateFrameNumber(nsecs_t latchTime) { 
    return NO_ERROR;

}



void BufferQueueLayer::setHwcLayerBuffer(DisplayId displayId) {

    auto& hwcInfo = getBE().mHwcLayers[displayId];

    auto& hwcLayer = hwcInfo.layer;

void BufferQueueLayer::setHwcLayerBuffer(const sp<const DisplayDevice>& display) {

    const auto outputLayer = findOutputLayerForDisplay(display);

    LOG_FATAL_IF(!outputLayer);

    LOG_FATAL_IF(!outputLayer->getState.hwc);

    auto& hwcLayer = (*outputLayer->getState().hwc).hwcLayer;



    uint32_t hwcSlot = 0;

    sp<GraphicBuffer> hwcBuffer;

    hwcInfo.bufferCache.getHwcBuffer(mActiveBufferSlot, mActiveBuffer, &hwcSlot, &hwcBuffer);

    (*outputLayer->editState().hwc)

            .hwcBufferCache.getHwcBuffer(mActiveBufferSlot, mActiveBuffer, &hwcSlot, &hwcBuffer);



    auto acquireFence = mConsumer->getCurrentFence();

    auto error = hwcLayer->setBuffer(hwcSlot, hwcBuffer, acquireFence);

services/surfaceflinger/BufferQueueLayer.h

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ private: 
    status_t updateActiveBuffer() override;

    status_t updateFrameNumber(nsecs_t latchTime) override;



    void setHwcLayerBuffer(DisplayId displayId) override;

    void setHwcLayerBuffer(const sp<const DisplayDevice>& displayDevice) override;



    // -----------------------------------------------------------------------

    // Interface implementation for BufferLayerConsumer::ContentsChangedListener

services/surfaceflinger/BufferStateLayer.cpp

+11 −8
Original line number Diff line number Diff line
@@ -19,15 +19,17 @@ 
#define LOG_TAG "BufferStateLayer"

#define ATRACE_TAG ATRACE_TAG_GRAPHICS



#include "BufferStateLayer.h"

#include "ColorLayer.h"



#include "TimeStats/TimeStats.h"

#include <limits>



#include <compositionengine/Display.h>

#include <compositionengine/OutputLayer.h>

#include <compositionengine/impl/OutputLayerCompositionState.h>

#include <private/gui/SyncFeatures.h>

#include <renderengine/Image.h>



#include <limits>

#include "BufferStateLayer.h"

#include "ColorLayer.h"

#include "TimeStats/TimeStats.h"



namespace android {
@@ -611,9 +613,10 @@ status_t BufferStateLayer::updateFrameNumber(nsecs_t /*latchTime*/) { 
    return NO_ERROR;

}



void BufferStateLayer::setHwcLayerBuffer(DisplayId displayId) {

    auto& hwcInfo = getBE().mHwcLayers[displayId];

    auto& hwcLayer = hwcInfo.layer;

void BufferStateLayer::setHwcLayerBuffer(const sp<const DisplayDevice>& display) {

    const auto outputLayer = findOutputLayerForDisplay(display);

    LOG_FATAL_IF(!outputLayer || !outputLayer->getState().hwc);

    auto& hwcLayer = (*outputLayer->getState().hwc).hwcLayer;



    const State& s(getDrawingState());