Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3548159e authored by Steven Moreland's avatar Steven Moreland Committed by Automerger Merge Worker
Browse files

Merge "libbinder: disable implicit unique_fd get" am: 7795accb am:... 

Merge "libbinder: disable implicit unique_fd get" am: 7795accb am: e8e37c2e am: e21cd392 am: 2b86119f

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/1499179

Change-Id: I97fae8a5f43437708902df0a3c433fce164fc79e
parents 4f08e843 2b86119f

libs/binder/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ cc_library { 
        "-Wextra",

        "-Werror",

        "-Wzero-as-null-pointer-constant",

        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION",

    ],

    product_variables: {

        binder32bit: {

libs/binder/include/binder/ParcelFileDescriptor.h

+6 −6
Original line number Diff line number Diff line
@@ -43,22 +43,22 @@ public: 
    android::status_t readFromParcel(const android::Parcel* parcel) override;



    inline bool operator!=(const ParcelFileDescriptor& rhs) const {

        return mFd != rhs.mFd;

        return mFd.get() != rhs.mFd.get();

    }

    inline bool operator<(const ParcelFileDescriptor& rhs) const {

        return mFd < rhs.mFd;

        return mFd.get() < rhs.mFd.get();

    }

    inline bool operator<=(const ParcelFileDescriptor& rhs) const {

        return mFd <= rhs.mFd;

        return mFd.get() <= rhs.mFd.get();

    }

    inline bool operator==(const ParcelFileDescriptor& rhs) const {

        return mFd == rhs.mFd;

        return mFd.get() == rhs.mFd.get();

    }

    inline bool operator>(const ParcelFileDescriptor& rhs) const {

        return mFd > rhs.mFd;

        return mFd.get() > rhs.mFd.get();

    }

    inline bool operator>=(const ParcelFileDescriptor& rhs) const {

        return mFd >= rhs.mFd;

        return mFd.get() >= rhs.mFd.get();

    }

private:

    android::base::unique_fd mFd;