Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34af0637 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: readString*Inplace SafetyNet (II) 

SafetyNet logs (this time for failure case, instead of success case).

Bug: 172655291
Test: adb logcat -b events | grep snet # exactly one occurance w/ repro
Change-Id: I75ace071693c0a4579ed9477f7b9212a6e27c36d
parent 60c8f56e

libs/binder/Parcel.cpp

+10 −4
Original line number Diff line number Diff line
@@ -2055,9 +2055,12 @@ const char* Parcel::readString8Inplace(size_t* outLen) const 
    if (size >= 0 && size < INT32_MAX) {

        *outLen = size;

        const char* str = (const char*)readInplace(size+1);

        if (str != nullptr && str[size] == '\0') {

        if (str != nullptr) {

            if (str[size] == '\0') {

                return str;

            }

            android_errorWriteLog(0x534e4554, "172655291");

        }

    }

    *outLen = 0;

    return nullptr;
@@ -2138,9 +2141,12 @@ const char16_t* Parcel::readString16Inplace(size_t* outLen) const 
    if (size >= 0 && size < INT32_MAX) {

        *outLen = size;

        const char16_t* str = (const char16_t*)readInplace((size+1)*sizeof(char16_t));

        if (str != nullptr && str[size] == u'\0') {

        if (str != nullptr) {

            if (str[size] == u'\0') {

                return str;

            }

            android_errorWriteLog(0x534e4554, "172655291");

        }

    }

    *outLen = 0;

    return nullptr;