Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32938bf4 authored by Naomi Luis's avatar Naomi Luis
Browse files

frameworks/base/opengl: Add NULL check 

Check for the validity of the attrs_list in eglChooseConfig before using
it. This avoids a crash during tests in which the attributes are NULL.

Change-Id: I1c0a46b505ae919e2454cfdce32f8dfc21ead247
parent 3af76d89

opengl/libs/EGL/egl.cpp

+7 −4
Original line number Diff line number Diff line
@@ -843,11 +843,14 @@ EGLBoolean eglChooseConfig( EGLDisplay dpy, const EGLint *attrib_list, 
    EGLint patch_index = -1;

    GLint attr;

    size_t size = 0;



    if (attrib_list != NULL) {

        while ((attr=attrib_list[size]) != EGL_NONE) {

            if (attr == EGL_CONFIG_ID)

                patch_index = size;

            size += 2;

        }

    }

    if (patch_index >= 0) {

        size += 2; // we need copy the sentinel as well

        EGLint* new_list = (EGLint*)malloc(size*sizeof(EGLint));