Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30a2d053 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Use -Werror in frameworks/native/libs/vr/libbufferhubqueue 

* Remove unused variable and private field.
Bug: 66996870
Test: build with WITH_TIDY=1

Change-Id: I6a1030748372912f52c6cc17116cb55dca5731fe
parent 1eaa1035

libs/vr/libbufferhubqueue/tests/Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -68,6 +68,8 @@ cc_benchmark { 
        "-DLOG_TAG=\"buffer_transport_benchmark\"",

        "-DTRACE=0",

        "-O2",

        "-Wall",

        "-Werror",

    ],

    name: "buffer_transport_benchmark",

    tags: ["optional"],

libs/vr/libbufferhubqueue/tests/buffer_transport_benchmark.cpp

+2 −5
Original line number Diff line number Diff line
@@ -34,7 +34,6 @@ using ::benchmark::State; 
static const String16 kBinderService = String16("bufferTransport");

static const uint32_t kBufferWidth = 100;

static const uint32_t kBufferHeight = 1;

static const uint32_t kBufferLayerCount = 1;

static const uint32_t kBufferFormat = HAL_PIXEL_FORMAT_BLOB;

static const uint64_t kBufferUsage =

    GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN;
@@ -75,10 +74,9 @@ class BufferTransportService : public BBinder { 
 private:

  struct FrameListener : public ConsumerBase::FrameAvailableListener {

   public:

    FrameListener(BufferTransportService* service,

    FrameListener(BufferTransportService* /*service*/,

                  sp<BufferItemConsumer> buffer_item_consumer)

        : service_(service),

          buffer_item_consumer_(buffer_item_consumer) {}

        : buffer_item_consumer_(buffer_item_consumer) {}



    void onFrameAvailable(const BufferItem& /*item*/) override {

      BufferItem buffer;
@@ -106,7 +104,6 @@ class BufferTransportService : public BBinder { 
    }



   private:

    BufferTransportService* service_ = nullptr;

    sp<BufferItemConsumer> buffer_item_consumer_;

  };