Commit 2d466008 authored Dec 29, 2022 by Steven Moreland

GraphicsBuffer: comparison operators

All AIDL structures are comparable. It makes it possible to use them as keys in a map. We can define an order for any type on the computer, since we can always take the address. Though - this may not always be the most useful meaning.

We didn't discover this earlier, because this was only ever used in an argument. Regardless, it seems like a useful thing to have.

Also - we shouldn't add complexity to AIDL to make this optional. It has deep consequences, since any element, even 4-5 structures deep could cause a struct to not be comparable. If someone adds a non-comparable type to a structure in a later version, AIDL packages depending on it might find it impossible to upgrade without making their structures non-comparable, which could break client code.

Bug: N/A
Test: N/A
Change-Id: I627adbd110d037246ce307f4984739008fe91c33

parent 015ae27a

libs/nativewindow/include/android/hardware_buffer_aidl.h

+7 −0

Original line number	Diff line number	Diff line
		@@ -119,6 +119,13 @@ public:
		inline AHardwareBuffer* _Nullable get() const { return mBuffer; }
		inline explicit operator bool () const { return mBuffer != nullptr; }

		inline bool operator!=(const HardwareBuffer& rhs) const { return get() != rhs.get(); }
		inline bool operator<(const HardwareBuffer& rhs) const { return get() < rhs.get(); }
		inline bool operator<=(const HardwareBuffer& rhs) const { return get() <= rhs.get(); }
		inline bool operator==(const HardwareBuffer& rhs) const { return get() == rhs.get(); }
		inline bool operator>(const HardwareBuffer& rhs) const { return get() > rhs.get(); }
		inline bool operator>=(const HardwareBuffer& rhs) const { return get() >= rhs.get(); }

		HardwareBuffer& operator=(HardwareBuffer&& other) noexcept {
		reset(other.release());
		return *this;