Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25d9cc5a authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: RPC clarify thread exhaustion log 

This log used the old 'client' 'server' terminology which in this
context was disambiguated to 'incoming' and 'outcoming' threads,
and it also now says what to do when threads are exhausted.

Note: as you can see from this log, RpcServer still needs a way
to limit the number of outgoing connections that it will create.

Fixes: 220177986
Test: binderRpcTest
Change-Id: Ib4c6bf654acd4a33d054d134ed578b40a976c314
parent 2362edf7

libs/binder/RpcSession.cpp

+10 −4
Original line number Diff line number Diff line
@@ -853,10 +853,16 @@ status_t RpcSession::ExclusiveConnection::find(const sp<RpcSession>& session, Co 
        }



        if (session->mConnections.mOutgoing.size() == 0) {

            ALOGE("Session has no client connections. This is required for an RPC server to make "

                  "any non-nested (e.g. oneway or on another thread) calls. Use: %d. Server "

                  "connections: %zu",

                  static_cast<int>(use), session->mConnections.mIncoming.size());

            ALOGE("Session has no outgoing connections. This is required for an RPC server to make "

                  "any non-nested (e.g. oneway or on another thread) calls. Use code request "

                  "reason: %d. Incoming connections: %zu. %s.",

                  static_cast<int>(use), session->mConnections.mIncoming.size(),

                  (session->server()

                           ? "This is a server session, so see RpcSession::setMaxIncomingThreads "

                             "for the corresponding client"

                           : "This is a client session, so see RpcSession::setMaxOutgoingThreads "

                             "for this client or RpcServer::setMaxThreads for the corresponding "

                             "server"));

            return WOULD_BLOCK;

        }