Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1be91350 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: sess getMaxThreads->getRemoteMaxThreads 

In Rpc_Sess_ion, since we will also support a session serving commands
(e.g. for callbacks).

Bug: 185167543
Test: binderRpcTest
Change-Id: I71c6b16d5b7d61f1cd4320443eae41fe08221b4f
parent a416e7b1

libs/binder/RpcSession.cpp

+2 −2
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ sp<IBinder> RpcSession::getRootObject() { 
    return state()->getRootObject(connection.fd(), sp<RpcSession>::fromExisting(this));

}



status_t RpcSession::getMaxThreads(size_t* maxThreads) {

status_t RpcSession::getRemoteMaxThreads(size_t* maxThreads) {

    ExclusiveConnection connection(sp<RpcSession>::fromExisting(this), ConnectionUse::CLIENT);

    return state()->getMaxThreads(connection.fd(), sp<RpcSession>::fromExisting(this), maxThreads);

}
@@ -201,7 +201,7 @@ bool RpcSession::setupSocketClient(const RpcSocketAddress& addr) { 
    // instead of all at once.

    // TODO(b/186470974): first risk of blocking

    size_t numThreadsAvailable;

    if (status_t status = getMaxThreads(&numThreadsAvailable); status != OK) {

    if (status_t status = getRemoteMaxThreads(&numThreadsAvailable); status != OK) {

        ALOGE("Could not get max threads after initial session to %s: %s", addr.toString().c_str(),

              statusToString(status).c_str());

        return false;

libs/binder/include/binder/RpcSession.h

+1 −1
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ public: 
     * Query the other side of the session for the maximum number of threads

     * it supports (maximum number of concurrent non-nested synchronous transactions)

     */

    status_t getMaxThreads(size_t* maxThreads);

    status_t getRemoteMaxThreads(size_t* maxThreads);



    [[nodiscard]] status_t transact(const RpcAddress& address, uint32_t code, const Parcel& data,

                                    Parcel* reply, uint32_t flags);