Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18db3454 authored by Ryan Prichard's avatar Ryan Prichard
Browse files

Suppress codecvt deprecation warnings 

This usage of codecvt to convert UTF-16 to UTF-8 generates a lot of
warnings.

Bug: 175635923
Bug: 244494451
Test: treehugger
Change-Id: Ic134f27e67007dff51b178d345a448af2af1d66d
parent 430dde3e

libs/binder/ndk/include_cpp/android/binder_to_string.h

+5 −0
Original line number Diff line number Diff line
@@ -162,7 +162,12 @@ std::string ToString(const _T& t) { 
    } else if constexpr (std::is_same_v<bool, _T>) {

        return t ? "true" : "false";

    } else if constexpr (std::is_same_v<char16_t, _T>) {

        // TODO(b/244494451): codecvt is deprecated in C++17 -- suppress the

        // warnings. There's no replacement in the standard library yet.

        _Pragma("clang diagnostic push")

                _Pragma("clang diagnostic ignored \"-Wdeprecated-declarations\"");

        return std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>().to_bytes(t);

        _Pragma("clang diagnostic pop");

    } else if constexpr (std::is_arithmetic_v<_T>) {

        return std::to_string(t);

    } else if constexpr (std::is_same_v<std::string, _T>) {