Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12f8913b authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

ftl_flags: Add default parameter to any() 

Add a default parameter to any() so that we can easily test if any of
the bits in the bitfield have been set.

Bug: 245989146
Test: atest ftl_test
Change-Id: Ibee03c2f70288d1a353e1d86539fb7f88b1e5d3c
parent ccda33e2

include/ftl/flags.h

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ public: 
    }



    /* Tests whether any of the given flags are set */

    bool any(Flags<F> f) const { return (mFlags & f.mFlags) != 0; }

    bool any(Flags<F> f = ~Flags<F>()) const { return (mFlags & f.mFlags) != 0; }



    /* Tests whether all of the given flags are set */

    bool all(Flags<F> f) const { return (mFlags & f.mFlags) == f.mFlags; }

libs/ftl/flags_test.cpp

+4 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ TEST(Flags, Test) { 


TEST(Flags, Any) {

    Flags<TestFlags> flags = TestFlags::ONE | TestFlags::TWO;

    ASSERT_TRUE(flags.any());

    ASSERT_TRUE(flags.any(TestFlags::ONE));

    ASSERT_TRUE(flags.any(TestFlags::TWO));

    ASSERT_FALSE(flags.any(TestFlags::THREE));
@@ -42,6 +43,9 @@ TEST(Flags, Any) { 
    ASSERT_TRUE(flags.any(TestFlags::TWO | TestFlags::THREE));

    ASSERT_TRUE(flags.any(TestFlags::ONE | TestFlags::THREE));

    ASSERT_TRUE(flags.any(TestFlags::ONE | TestFlags::TWO | TestFlags::THREE));



    Flags<TestFlags> emptyFlags;

    ASSERT_FALSE(emptyFlags.any());

}



TEST(Flags, All) {