Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e14b506 authored by Nolan Scobie's avatar Nolan Scobie
Browse files

[RE] Change KawaseBlurFilter's temp SkSurface to be unbudgeted 

This means it won't count against Skia's internal caching budget.

Since this is so short lived I doubt it will affect anything in practice,
but it's important to change for clarity for two reasons:
1. The equivalent Graphite function doesn't allow the SkSurface to
be budgeted.
2. When `surfaceTwo` is created from `surface`, the result is always
unbudgeted. See TODO in `SkSurface_Ganesh::onNewSurface` of
external/skia/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp

Bug: 293371537
Change-Id: Icd91aaa5b6385458eb92d385241d27c19dd6cce4
parent f8680e6d

libs/renderengine/skia/filters/KawaseBlurFilter.cpp

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ sk_sp<SkImage> KawaseBlurFilter::generate(GrRecordingContext* context, 
    constexpr int kSampleCount = 1;

    constexpr bool kMipmapped = false;

    constexpr SkSurfaceProps* kProps = nullptr;

    sk_sp<SkSurface> surface = SkSurfaces::RenderTarget(context, skgpu::Budgeted::kYes, scaledInfo,

    sk_sp<SkSurface> surface = SkSurfaces::RenderTarget(context, skgpu::Budgeted::kNo, scaledInfo,

                                                        kSampleCount, kTopLeft_GrSurfaceOrigin,

                                                        kProps, kMipmapped, input->isProtected());

    LOG_ALWAYS_FATAL_IF(!surface, "%s: Failed to create surface for blurring!", __func__);