Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bed1f54 authored by Dave Burke's avatar Dave Burke Committed by Android (Google) Code Review
Browse files

Revert "ugly, temporary, workaroung for a problem where a binder thread spins forever" 

This reverts commit 0845d024

Change-Id: I395037cb9427cd11f7de6bb78fbdfa917fc6263a
parent 0845d024

libs/binder/IPCThreadState.cpp

+0 −12
Original line number Diff line number Diff line
@@ -482,18 +482,6 @@ void IPCThreadState::joinThreadPool(bool isMain) 
        if(result == TIMED_OUT && !isMain) {

            break;

        }



        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK

        // FIXME: we sometimes get unexplained EINVAL which causes this

        // thread to spin forever. TEMPORARILY allow it to exit.

        // We should probably assert on eng builds

        if(result == -EINVAL && !isMain) {

            ALOGE("**** THREAD %p (PID %d) ERROR (%d) LEAVING THE THREAD POOL\n",

                (void*)pthread_self(), getpid(), result);

            break;

        }

        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK



    } while (result != -ECONNREFUSED && result != -EBADF);



    LOG_THREADPOOL("**** THREAD %p (PID %d) IS LEAVING THE THREAD POOL err=%p\n",