Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 092123cf authored by Jorim Jaggi's avatar Jorim Jaggi
Browse files

Revert "Death to synchronous transactions (1/2)" 

This reverts commit c6a607aa.

It causes issues when resizing: default buffer size on the consumer side
only gets set when the transaction actually executes. But because
consumer is not blocked on SF over WM anymore, it gets the default
buffer size before the surface is resized, and thus uses wrong bounds
for the buffer to be drawn, and never submits another one.

This needs a more involved fix.

Bug: 28122036
Bug: 28128613
Change-Id: I0e738f99e43fc9ea25426e9e6e607e01413d3bb7
parent c6a607aa

libs/gui/SurfaceComposerClient.cpp

+4 −0
Original line number Diff line number Diff line
@@ -291,6 +291,9 @@ status_t Composer::setSize(const sp<SurfaceComposerClient>& client, 
    s->w = w;

    s->h = h;



    // Resizing a surface makes the transaction synchronous.

    mForceSynchronous = true;



    return NO_ERROR;

}
@@ -451,6 +454,7 @@ void Composer::setDisplayProjection(const sp<IBinder>& token, 
    s.viewport = layerStackRect;

    s.frame = displayRect;

    s.what |= DisplayState::eDisplayProjectionChanged;

    mForceSynchronous = true; // TODO: do we actually still need this?

}



void Composer::setDisplaySize(const sp<IBinder>& token, uint32_t width, uint32_t height) {