Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07247342 authored by Siarhei Vishniakou's avatar Siarhei Vishniakou
Browse files

Pass by reference instead of pointer 

When the parameters are assumed to be non-null, they should be passed by
reference instead of by pointer.


Bug: 239182977
Test: atest inputflinger_tests
Change-Id: Ifd21a87020f2e9056b3a233ddd33d3f3440b94ee
parent 2421088b

services/inputflinger/reader/mapper/TouchInputMapper.cpp

+8 −5
Original line number Diff line number Diff line
@@ -2231,13 +2231,16 @@ void TouchInputMapper::cookPointerData() { 
                    toolMinor = toolMajor;

                }



                mCalibration.applySizeScaleAndBias(&touchMajor);

                mCalibration.applySizeScaleAndBias(&touchMinor);

                mCalibration.applySizeScaleAndBias(&toolMajor);

                mCalibration.applySizeScaleAndBias(&toolMinor);

                mCalibration.applySizeScaleAndBias(touchMajor);

                mCalibration.applySizeScaleAndBias(touchMinor);

                mCalibration.applySizeScaleAndBias(toolMajor);

                mCalibration.applySizeScaleAndBias(toolMinor);

                size *= mSizeScale;

                break;

            default:

            case Calibration::SizeCalibration::DEFAULT:

                LOG_ALWAYS_FATAL("Resolution should not be 'DEFAULT' at this point");

                break;

            case Calibration::SizeCalibration::NONE:

                touchMajor = 0;

                touchMinor = 0;

                toolMajor = 0;

services/inputflinger/reader/mapper/TouchInputMapper.h

+5 −5
Original line number Diff line number Diff line
@@ -291,15 +291,15 @@ protected: 


        CoverageCalibration coverageCalibration;



        inline void applySizeScaleAndBias(float* outSize) const {

        inline void applySizeScaleAndBias(float& outSize) const {

            if (sizeScale) {

                *outSize *= *sizeScale;

                outSize *= *sizeScale;

            }

            if (sizeBias) {

                *outSize += *sizeBias;

                outSize += *sizeBias;

            }

            if (*outSize < 0) {

                *outSize = 0;

            if (outSize < 0) {

                outSize = 0;

            }

        }

    } mCalibration;