Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 052a957a authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: don't ignore sendDecStrong error 

I am not sure why this was ignored before, but I can't think of any
reason why it should be. Fail hard fail fast.

Note: this is being submitted independently in preparation for a series
of refcount changes related to performance.

Bug: 182940634
Test: binderRpcTest
Change-Id: Ifcc0bf96952a368c4ad5620b3f1d2d17feac40c5
parent abecf2e9

libs/binder/RpcState.cpp

+1 −3
Original line number Original line Diff line number Diff line
@@ -166,9 +166,7 @@ status_t RpcState::onBinderEntering(const sp<RpcSession>& session, uint64_t addr 
        // We have timesRecd RPC refcounts, but we only need to hold on to one

        // We have timesRecd RPC refcounts, but we only need to hold on to one

        // when we keep the object. All additional dec strongs are sent

        // when we keep the object. All additional dec strongs are sent

        // immediately, we wait to send the last one in BpBinder::onLastDecStrong.

        // immediately, we wait to send the last one in BpBinder::onLastDecStrong.

        (void)session->sendDecStrong(address);

        return session->sendDecStrong(address);



        return OK;

    }

    }





    // we don't know about this binder, so the other side of the connection

    // we don't know about this binder, so the other side of the connection