Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0278db49 authored by Cody Northrop's avatar Cody Northrop
Browse files

EGL BlobCache: Disable multifile to address Wembley perf 

Need to investigate multifile performance on Wembley, which does
not use SkiaVk.  That means many small/simple GL programs are taking
longer to start.  Accessing the filesystem is taking longer than a
quick return from a sub 1MB cache.

Test: Build and inspect cache locally
Test: /data/nativetest64/EGL_test/EGL_test
Bug: b/263574392
Change-Id: Iacc725f902fd91c7cbd06b293ec96f5ab5eeb1c3
parent 990ff7ba

opengl/libs/EGL/egl_cache.cpp

+1 −3
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ static EGLsizeiANDROID getBlob(const void* key, EGLsizeiANDROID keySize, void* v 
//

egl_cache_t::egl_cache_t()

      : mInitialized(false),

        mMultifileMode(true),

        mMultifileMode(false),

        mCacheByteLimit(maxTotalSize),

        mMultifileCleanupPending(false) {}
@@ -114,8 +114,6 @@ void egl_cache_t::initialize(egl_display_t* display) { 
        }

    }



    mMultifileMode = true;



    // Allow forcing monolithic cache for debug purposes

    if (base::GetProperty("debug.egl.blobcache.multifilemode", "") == "false") {

        ALOGD("Forcing monolithic cache due to debug.egl.blobcache.multifilemode == \"false\"");

opengl/tests/EGLTest/egl_cache_test.cpp

+3 −0
Original line number Diff line number Diff line
@@ -134,6 +134,9 @@ std::string EGLCacheTest::getCachefileName() { 
}



TEST_F(EGLCacheTest, ModifiedCacheMisses) {

    // Turn this back on if multifile becomes the default

    GTEST_SKIP() << "Skipping test designed for multifile, see b/263574392 and b/246966894";



    uint8_t buf[4] = { 0xee, 0xee, 0xee, 0xee };

    mCache->initialize(egl_display_t::get(EGL_DEFAULT_DISPLAY));