Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit ae58d93d authored by tobiasKaminsky's avatar tobiasKaminsky
Browse files

fix spotbugs 



Signed-off-by: default avatartobiasKaminsky <tobias@kaminsky.me>
parent d4e4506c

library/src/main/java/com/owncloud/android/lib/common/network/WebdavEntry.java

+4 −5
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ public class WebdavEntry { 
    @Getter

    private String lockToken = null;

    @Getter

    @SuppressFBWarnings("EI_EXPOSE_REP")

    private String[] tags = new String[0];



    public enum MountType {INTERNAL, EXTERNAL, GROUP}
@@ -439,13 +440,11 @@ public class WebdavEntry { 
            prop = propSet.get(EXTENDED_PROPERTY_SYSTEM_TAGS, ncNamespace);

            if (prop != null && prop.getValue() != null) {

                if (prop.getValue() instanceof ArrayList) {

                    ArrayList list = (ArrayList) prop.getValue();



                    List<String> tempList = new ArrayList<>();

                    ArrayList<Element> list = (ArrayList<Element>) prop.getValue();



                    for (int i = 0; i < list.size(); i++) {

                        Element element = (Element) list.get(i);

                    List<String> tempList = new ArrayList<>(list.size());



                    for (Element element : list) {

                        tempList.add(element.getFirstChild().getTextContent());

                    }

library/src/main/java/com/owncloud/android/lib/resources/files/model/RemoteFile.java

+2 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ import com.owncloud.android.lib.resources.shares.ShareeUser; 


import java.io.Serializable;



import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import lombok.Getter;

import lombok.Setter;
@@ -78,6 +79,7 @@ public class RemoteFile implements Parcelable, Serializable { 
    private String lockOwnerEditor;

    private long lockTimeout;

    private String lockToken;

    @SuppressFBWarnings("EI_EXPOSE_REP")

    private String[] tags;



    public RemoteFile() {

library/src/main/java/com/owncloud/android/lib/resources/tags/GetTagsRemoteOperation.kt

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ import org.apache.jackrabbit.webdav.client.methods.PropFindMethod 
import org.apache.jackrabbit.webdav.property.DavPropertyName

import org.apache.jackrabbit.webdav.property.DavPropertyNameSet



class GetTagsRemoteOperation() : RemoteOperation<List<Tag>>() {

class GetTagsRemoteOperation : RemoteOperation<List<Tag>>() {

    @Deprecated("Deprecated in Java")

    override fun run(client: OwnCloudClient): RemoteOperationResult<List<Tag>> {

        val propertyId = DavPropertyName.create(WebdavEntry.EXTENDED_PROPERTY_NAME_REMOTE_ID)