From 54883e6914edc1d5688520056133ef015ae55438 Mon Sep 17 00:00:00 2001
From: Fahim Salam Chowdhury <fahim@e.email>
Date: Tue, 26 Apr 2022 11:09:43 +0600
Subject: [PATCH] 5034-Fix_unreade_mail_item_background_transparent_issue

issue: https://gitlab.e.foundation/e/backlog/-/issues/5034

Unread messageItem has a kind-of transparent background color, which
sometimes create issue on item draw. This commit change the background
color to its counterpart solid color.
---
 app/k9mail-jmap/src/main/res/values/themes.xml                | 4 ++--
 app/k9mail/src/main/res/values-night/colors.xml               | 2 +-
 app/k9mail/src/main/res/values/colors.xml                     | 2 +-
 app/k9mail/src/main/res/values/themes.xml                     | 2 +-
 .../src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt  | 3 ++-
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/k9mail-jmap/src/main/res/values/themes.xml b/app/k9mail-jmap/src/main/res/values/themes.xml
index 092f7eb934..c59116162c 100644
--- a/app/k9mail-jmap/src/main/res/values/themes.xml
+++ b/app/k9mail-jmap/src/main/res/values/themes.xml
@@ -81,7 +81,7 @@
         <item name="textColorSecondaryRecipientDropdown">@android:color/secondary_text_light</item>
         <item name="messageListSelectedBackgroundColor">#8038B8E2</item>
         <item name="messageListReadItemBackgroundColor">#c0cdcdcd</item>
-        <item name="messageListUnreadItemBackgroundColor">#00ffffff</item>
+        <item name="messageListUnreadItemBackgroundColor">#DCDCDC</item>
         <item name="messageListThreadCountForegroundColor">?android:attr/colorBackground</item>
         <item name="messageListThreadCountBackground">@drawable/thread_count_box_light</item>
         <item name="messageListActiveItemBackgroundColor">#ff2ea7d1</item>
@@ -200,7 +200,7 @@
         <item name="textColorSecondaryRecipientDropdown">@android:color/secondary_text_dark</item>
         <item name="messageListSelectedBackgroundColor">#8038B8E2</item>
         <item name="messageListReadItemBackgroundColor">#00000000</item>
-        <item name="messageListUnreadItemBackgroundColor">#c05a5a5a</item>
+        <item name="messageListUnreadItemBackgroundColor">#2F2F2F</item>
         <item name="messageListThreadCountForegroundColor">?android:attr/colorBackground</item>
         <item name="messageListThreadCountBackground">@drawable/thread_count_box_dark</item>
         <item name="messageListActiveItemBackgroundColor">#ff33b5e5</item>
diff --git a/app/k9mail/src/main/res/values-night/colors.xml b/app/k9mail/src/main/res/values-night/colors.xml
index 8289f8c154..d36ff2bd1d 100644
--- a/app/k9mail/src/main/res/values-night/colors.xml
+++ b/app/k9mail/src/main/res/values-night/colors.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <color name="color_message_list_unread_background">#1FFFFFFF</color>
+    <color name="color_message_list_unread_background">#2F2F2F</color>
     <color name="color_message_list_thread_count_background">#61FFFFFF</color>
 </resources>
\ No newline at end of file
diff --git a/app/k9mail/src/main/res/values/colors.xml b/app/k9mail/src/main/res/values/colors.xml
index cfe20f6213..9de6b37af1 100644
--- a/app/k9mail/src/main/res/values/colors.xml
+++ b/app/k9mail/src/main/res/values/colors.xml
@@ -12,6 +12,6 @@
     <color name="color_default_gray2">@lineageos.platform:color/color_default_gray2</color>
 
     <color name="color_message_list_selected_background">@lineageos.platform:color/color_default_selector_background</color>
-    <color name="color_message_list_unread_background">#1F000000</color>
+    <color name="color_message_list_unread_background">#DCDCDC</color>
     <color name="color_message_list_thread_count_background">#61000000</color>
 </resources>
\ No newline at end of file
diff --git a/app/k9mail/src/main/res/values/themes.xml b/app/k9mail/src/main/res/values/themes.xml
index 1951ae4cc9..2e7b59f7a6 100644
--- a/app/k9mail/src/main/res/values/themes.xml
+++ b/app/k9mail/src/main/res/values/themes.xml
@@ -214,7 +214,7 @@
         <item name="textColorSecondaryRecipientDropdown">@color/color_default_secondary_text</item>
         <item name="messageListSelectedBackgroundColor">@color/color_message_list_selected_background</item>
         <item name="messageListReadItemBackgroundColor">#c0cdcdcd</item>
-        <item name="messageListUnreadItemBackgroundColor">#00ffffff</item>
+        <item name="messageListUnreadItemBackgroundColor">@color/color_message_list_unread_background</item>
         <item name="messageListThreadCountForegroundColor">?android:attr/colorBackground</item>
         <item name="messageListThreadCountBackground">@drawable/thread_count_box_light</item>
         <item name="messageListActiveItemBackgroundColor">@color/color_default_accent</item>
diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt b/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
index 0c026017b3..e07b709cf2 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
+++ b/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
@@ -17,6 +17,7 @@ import android.view.ViewGroup
 import android.widget.BaseAdapter
 import android.widget.ImageView
 import android.widget.TextView
+import androidx.core.content.ContextCompat
 import androidx.core.graphics.drawable.DrawableCompat
 import androidx.core.view.isVisible
 import com.fsck.k9.FontSizes
@@ -256,7 +257,7 @@ class MessageListAdapter internal constructor(
             selected -> selectedItemBackgroundColor
             backGroundAsReadIndicator && read -> readItemBackgroundColor
             backGroundAsReadIndicator && !read -> unreadItemBackgroundColor
-            else -> Color.TRANSPARENT
+            else -> ContextCompat.getColor(view.context, R.color.color_default_background)
         }
 
         view.setBackgroundColor(backgroundColor)
-- 
GitLab