From 97164a5fe450034a9e87dd55531584bcf23950c5 Mon Sep 17 00:00:00 2001 From: Fahim Salam Chowdhury Date: Tue, 8 Mar 2022 13:42:56 +0600 Subject: [PATCH] 18-Move_answer_button_to_actionbar issue: https://gitlab.e.foundation/e/os/backlog/-/issues/18 In messageView, the send option has 2 ways to access it, via more options in actionBar & button in headerView. As per discussion, we want only single send button accessed from actionBar (not hidden behind more options). This commit does the following: - set the actionBar `single_message_options`'s `showAsAction="always"` - set invisible message_view_header's `icon_single_message_options` (don't set visibility=gone as other views are constrained against this imageView) --- app/ui/legacy/src/main/res/layout/message_view_header.xml | 1 + app/ui/legacy/src/main/res/menu/message_list_option.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/ui/legacy/src/main/res/layout/message_view_header.xml b/app/ui/legacy/src/main/res/layout/message_view_header.xml index 53a076f3e8..4c822cf73d 100644 --- a/app/ui/legacy/src/main/res/layout/message_view_header.xml +++ b/app/ui/legacy/src/main/res/layout/message_view_header.xml @@ -279,6 +279,7 @@ app:srcCompat="?iconActionSingleMessageOptions" android:padding="8dp" android:background="?selectableItemBackground" + android:visibility="invisible" /> diff --git a/app/ui/legacy/src/main/res/menu/message_list_option.xml b/app/ui/legacy/src/main/res/menu/message_list_option.xml index 04e2462797..415c8fe249 100644 --- a/app/ui/legacy/src/main/res/menu/message_list_option.xml +++ b/app/ui/legacy/src/main/res/menu/message_list_option.xml @@ -95,7 +95,7 @@