From 571cbe11bfc419383b1f0cb2710d7d024b62b10d Mon Sep 17 00:00:00 2001
From: Fahim Salam Chowdhury <fahim@e.email>
Date: Wed, 2 Mar 2022 12:26:08 +0600
Subject: [PATCH] 4982-Hide_blank_star_from_mailList

issue: https://gitlab.e.foundation/e/backlog/-/issues/4982

- set stat checkBox in message_list_item enable=false to disable click
  event
- disable visibility `messagelist_stars` preference option as it will no
  longer required
- update star checkBox's buttonIcon
---
 .../main/java/com/fsck/k9/fragment/MessageListAdapter.kt  | 8 +++++---
 app/ui/legacy/src/main/res/layout/message_list_item.xml   | 5 +++--
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt b/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
index 8557259efb..c56149f6c5 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
+++ b/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListAdapter.kt
@@ -124,9 +124,9 @@ class MessageListAdapter internal constructor(
         appearance.fontSizes.setViewTextSize(holder.preview, appearance.fontSizes.messageListPreview)
         appearance.fontSizes.setViewTextSize(holder.threadCount, appearance.fontSizes.messageListSubject) // thread count is next to subject
 
-        holder.flagged.isVisible = appearance.stars
+        holder.flagged.isVisible = false
         holder.flagged.tag = holder
-        holder.flagged.setOnClickListener(flagClickListener)
+        holder.flagged.setOnClickListener(null)
 
         view.tag = holder
 
@@ -167,7 +167,9 @@ class MessageListAdapter internal constructor(
             }
 
             if (appearance.stars) {
-                holder.flagged.isChecked = isStarred
+                holder.flagged.isVisible = isStarred
+            } else {
+                holder.flagged.isVisible = false
             }
             holder.position = position
             if (appearance.showContactPicture && holder.contactPicture.isVisible) {
diff --git a/app/ui/legacy/src/main/res/layout/message_list_item.xml b/app/ui/legacy/src/main/res/layout/message_list_item.xml
index 76435e58c6..fabbacbb8d 100644
--- a/app/ui/legacy/src/main/res/layout/message_list_item.xml
+++ b/app/ui/legacy/src/main/res/layout/message_list_item.xml
@@ -147,14 +147,15 @@
 
             <CheckBox
                 android:id="@+id/star"
-                style="@style/MessageStarStyle"
-                android:buttonTint="@color/star_color"
+                android:button="@drawable/ic_star"
+                android:buttonTint="@lineageos.platform:color/color_default_orange1"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:paddingTop="2dp"
                 android:paddingBottom="2dp"
                 android:layout_marginEnd="8dp"
                 android:focusable="false"
+                android:enabled="false"
                 android:visibility="visible"
                 android:gravity="center_vertical"
                 tools:text="&#x200B;"/>
-- 
GitLab