From 902dae0dbd391cd429ecff43f7fef44fbdf7a554 Mon Sep 17 00:00:00 2001
From: Sayantan Roychowdhury <sayantan.rc@e.email>
Date: Tue, 28 Feb 2023 18:15:45 +0530
Subject: [PATCH 1/2] align the star

---
 app/ui/legacy/src/main/res/layout/message_list_item.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/ui/legacy/src/main/res/layout/message_list_item.xml b/app/ui/legacy/src/main/res/layout/message_list_item.xml
index 1880e3581e..eff282e7d6 100644
--- a/app/ui/legacy/src/main/res/layout/message_list_item.xml
+++ b/app/ui/legacy/src/main/res/layout/message_list_item.xml
@@ -49,18 +49,18 @@
                     android:layout_height="wrap_content"
                     android:layout_alignParentStart="true"
                     android:layout_alignParentTop="true"
+                    android:gravity="center_vertical"
                     android:layout_toStartOf="@+id/date">
 
                     <CheckBox
                         android:id="@+id/star"
                         android:layout_width="16dp"
                         android:layout_height="16dp"
-                        android:layout_marginTop="4dp"
-                        android:layout_marginEnd="9dp"
                         android:button="@drawable/ic_star"
                         android:enabled="false"
                         android:focusable="false"
                         android:gravity="center_vertical"
+                        android:layout_marginEnd="12dp"
                         android:visibility="visible"
                         tools:text="&#x200B;" />
 
-- 
GitLab


From 6a9862cfccffebcd94eb746358dd65272e775d6f Mon Sep 17 00:00:00 2001
From: Sayantan Roychowdhury <sayantan.rc@e.email>
Date: Tue, 28 Feb 2023 19:29:14 +0530
Subject: [PATCH 2/2] change position of green dot and center align

---
 .../src/main/res/layout/message_list_item.xml | 20 +++++++++----------
 .../legacy/src/main/res/values/dimensions.xml |  4 ++++
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/app/ui/legacy/src/main/res/layout/message_list_item.xml b/app/ui/legacy/src/main/res/layout/message_list_item.xml
index eff282e7d6..a74fd2deb3 100644
--- a/app/ui/legacy/src/main/res/layout/message_list_item.xml
+++ b/app/ui/legacy/src/main/res/layout/message_list_item.xml
@@ -21,21 +21,11 @@
             android:layout_gravity="center_vertical"
             android:orientation="horizontal">
 
-            <View
-                android:id="@+id/unread_message_indicator"
-                android:layout_width="10dp"
-                android:layout_height="10dp"
-                android:layout_marginStart="12dp"
-                android:layout_marginTop="15dp"
-                android:background="@drawable/ic_unread_message"
-                android:visibility="invisible" />
-
             <RelativeLayout
                 android:id="@+id/list_item_inner"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_vertical"
-                android:layout_marginStart="13dp"
                 android:layout_marginTop="7dp"
                 android:layout_marginEnd="4dp"
                 android:layout_marginBottom="7dp"
@@ -52,6 +42,15 @@
                     android:gravity="center_vertical"
                     android:layout_toStartOf="@+id/date">
 
+                    <View
+                        android:id="@+id/unread_message_indicator"
+                        android:layout_width="10dp"
+                        android:layout_height="10dp"
+                        android:layout_marginStart="12dp"
+                        android:layout_marginEnd="13dp"
+                        android:background="@drawable/ic_unread_message"
+                        android:visibility="invisible" />
+
                     <CheckBox
                         android:id="@+id/star"
                         android:layout_width="16dp"
@@ -82,6 +81,7 @@
                     android:layout_height="wrap_content"
                     android:layout_below="@+id/subject_wrapper"
                     android:layout_alignParentStart="true"
+                    android:layout_marginStart="@dimen/messageListItemStartPadding"
                     android:layout_toStartOf="@id/extra_info_holder">
 
                     <ImageView
diff --git a/app/ui/legacy/src/main/res/values/dimensions.xml b/app/ui/legacy/src/main/res/values/dimensions.xml
index 5953db7e0a..c58d0e1fca 100644
--- a/app/ui/legacy/src/main/res/values/dimensions.xml
+++ b/app/ui/legacy/src/main/res/values/dimensions.xml
@@ -18,4 +18,8 @@
     <dimen name="floatingActionButtonMargin">16dp</dimen>
     <!-- Height of ExtendedFloatingActionButton (48dp) plus two times floatingActionButtonMargin -->
     <dimen name="floatingActionButtonSpacing">80dp</dimen>
+
+    <!-- This padding is calculated from unread_message_indicator-->
+    <!-- Equals size of the dot (10dp) + left margin (12dp) + right margin (13dp) -->
+    <dimen name="messageListItemStartPadding">34dp</dimen>
 </resources>
-- 
GitLab