Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit da8cbbe5 authored by Wolf-Martell Montwé's avatar Wolf-Martell Montwé Committed by GitHub
Browse files

Merge pull request #9209 from shamim-emon/fix-issue-9196 

Feat: add support for section divider for new preference system
parents 4130c037 aeba89fd

core/ui/compose/preference/src/main/kotlin/net/thunderbird/core/ui/compose/preference/api/Preference.kt

+5 −0
Original line number Diff line number Diff line
@@ -97,4 +97,9 @@ sealed interface PreferenceDisplay : Preference { 
        val title: () -> String,

        val color: () -> Color = { Color.Unspecified },

    ) : PreferenceDisplay



    @Parcelize

    data class SectionDivider(

        override val id: String,

    ) : PreferenceDisplay

}

core/ui/compose/preference/src/main/kotlin/net/thunderbird/core/ui/compose/preference/ui/components/list/PreferenceItem.kt

+6 −0
Original line number Diff line number Diff line
@@ -61,5 +61,11 @@ internal fun PreferenceItem( 
                modifier = modifier,

            )

        }



        is PreferenceDisplay.SectionDivider -> {

            PreferenceItemSectionDividerView(

                modifier = modifier,

            )

        }

    }

}

core/ui/compose/preference/src/main/kotlin/net/thunderbird/core/ui/compose/preference/ui/components/list/PreferenceItemSectionDividerView.kt

0 → 100644
+14 −0
Original line number Diff line number Diff line 
package net.thunderbird.core.ui.compose.preference.ui.components.list



import androidx.compose.runtime.Composable

import androidx.compose.ui.Modifier

import app.k9mail.core.ui.compose.designsystem.atom.DividerHorizontal



@Composable

internal fun PreferenceItemSectionDividerView(

    modifier: Modifier = Modifier,

) {

    DividerHorizontal(

        modifier = modifier,

    )

}

feature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/fake/FakePreferenceData.kt

+5 −0
Original line number Diff line number Diff line
@@ -53,6 +53,10 @@ object FakePreferenceData { 
        },

    )



    val sectionDivider = PreferenceDisplay.SectionDivider(

        id = "section_divider",

    )



    val sectionHeader = PreferenceDisplay.SectionHeader(

        id = "section_header",

        title = { "Section Title" },
@@ -64,5 +68,6 @@ object FakePreferenceData { 
        colorPreference,

        customPreference,

        sectionHeader,

        sectionDivider,

    )

}