use isEmpty instead of size() == 0 for clarify (d38f2126) · Commits · e / os / Mail

src/com/fsck/k9/Preferences.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -39,7 +39,7 @@ public class Preferences {
		private Preferences(Context context) {
		mStorage = Storage.getStorage(context);
		mContext = context;
		if (mStorage.size() == 0) {
		if (mStorage.isEmpty()) {
		Log.i(K9.LOG_TAG, "Preferences storage is zero-size, importing from Android-style preferences");
		Editor editor = mStorage.edit();
		editor.copy(context.getSharedPreferences("AndroidMail.Main", Context.MODE_PRIVATE));

+1 −1

Original line number	Diff line number	Diff line
		@@ -1056,7 +1056,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
		}

		private boolean addRecipients(TextView view, List<String> recipients) {
		if (recipients == null \|\| recipients.size() == 0) {
		if (recipients == null \|\| recipients.isEmpty()) {
		return false;
		}

+2 −2

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ public class EmailProviderCache {
		Map<String, String> map = mMessageCache.get(messageId);
		if (map != null) {
		map.remove(columnName);
		if (map.size() == 0) {
		if (map.isEmpty()) {
		mMessageCache.remove(messageId);
		}
		}
		@@ -115,7 +115,7 @@ public class EmailProviderCache {
		Map<String, String> map = mThreadCache.get(threadRootId);
		if (map != null) {
		map.remove(columnName);
		if (map.size() == 0) {
		if (map.isEmpty()) {
		mThreadCache.remove(threadRootId);
		}
		}

+2 −2

Original line number	Diff line number	Diff line
		@@ -108,7 +108,7 @@ public class EmailProviderCacheCursor extends CursorWrapper {

		@Override
		public boolean moveToPosition(int position) {
		if (mHiddenRows.size() == 0) {
		if (mHiddenRows.isEmpty()) {
		return super.moveToPosition(position);
		}

		@@ -126,7 +126,7 @@ public class EmailProviderCacheCursor extends CursorWrapper {

		@Override
		public int getPosition() {
		if (mHiddenRows.size() == 0) {
		if (mHiddenRows.isEmpty()) {
		return super.getPosition();
		}

+5 −5

Original line number	Diff line number	Diff line
		@@ -1814,7 +1814,7 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
		}

		List<String> folderNames = mSearch.getFolderNames();
		return (folderNames.size() == 0 \|\| folderNames.contains(folder));
		return (folderNames.isEmpty() \|\| folderNames.contains(folder));
		}
		}

		@@ -2362,7 +2362,7 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
		}

		private void setFlagForSelected(final Flag flag, final boolean newState) {
		if (mSelected.size() == 0) {
		if (mSelected.isEmpty()) {
		return;
		}

		@@ -2586,7 +2586,7 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
		private boolean checkCopyOrMovePossible(final List<Message> messages,
		final FolderOperation operation) {

		if (messages.size() == 0) {
		if (messages.isEmpty()) {
		return false;
		}

		@@ -3515,7 +3515,7 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
		}

		private void cleanupSelected(Cursor cursor) {
		if (mSelected.size() == 0) {
		if (mSelected.isEmpty()) {
		return;
		}

		@@ -3534,7 +3534,7 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
		* Starts or finishes the action mode when necessary.
		*/
		private void resetActionMode() {
		if (mSelected.size() == 0) {
		if (mSelected.isEmpty()) {
		if (mActionMode != null) {
		mActionMode.finish();
		}