diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java b/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java index 3e8630d453fea801dfb194a041d786ba8361c019..00a447c1e721134fe40c7abcc504fe5511a9a250 100644 --- a/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java +++ b/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java @@ -141,7 +141,7 @@ public class OpenPgpAppSelectDialog extends FragmentActivity { // search for OpenPGP providers... Intent intent = new Intent(OpenPgpApi.SERVICE_INTENT_2); List resInfo = getActivity().getPackageManager().queryIntentServices(intent, 0); - boolean hasNonBlacklistedChoices = false; + boolean hasAllowedChoices = false; if (resInfo != null) { for (ResolveInfo resolveInfo : resInfo) { if (resolveInfo.serviceInfo == null) { @@ -152,14 +152,14 @@ public class OpenPgpAppSelectDialog extends FragmentActivity { String simpleName = String.valueOf(resolveInfo.serviceInfo.loadLabel(context.getPackageManager())); Drawable icon = resolveInfo.serviceInfo.loadIcon(context.getPackageManager()); - if (!OpenPgpProviderUtil.isBlacklisted(packageName)) { + if (OpenPgpProviderUtil.isProviderAllowed(packageName)) { openPgpProviderList.add(new OpenPgpProviderEntry(packageName, simpleName, icon)); - hasNonBlacklistedChoices = true; + hasAllowedChoices = true; } } } - if (!hasNonBlacklistedChoices) { + if (!hasAllowedChoices) { // add install links if provider list is empty resInfo = context.getPackageManager().queryIntentActivities(MARKET_INTENT, 0); for (ResolveInfo resolveInfo : resInfo) { diff --git a/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpProviderUtil.java b/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpProviderUtil.java index d412fdfac37e7914ebd359e7e523cbee932f229d..b5e9b1e802d4fd6df64e8730c1e84b596f402114 100644 --- a/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpProviderUtil.java +++ b/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpProviderUtil.java @@ -12,9 +12,9 @@ import android.content.pm.ResolveInfo; public class OpenPgpProviderUtil { private static final String PACKAGE_NAME_APG = "org.thialfihar.android.apg"; - private static final ArrayList PROVIDER_BLACKLIST = new ArrayList<>(); + private static final ArrayList DISALLOWED_PROVIDERS = new ArrayList<>(); static { - PROVIDER_BLACKLIST.add(PACKAGE_NAME_APG); + DISALLOWED_PROVIDERS.add(PACKAGE_NAME_APG); } public static List getOpenPgpProviderPackages(Context context) { @@ -56,7 +56,7 @@ public class OpenPgpProviderUtil { return null; } - public static boolean isBlacklisted(String packageName) { - return PROVIDER_BLACKLIST.contains(packageName); + public static boolean isProviderAllowed(String packageName) { + return !DISALLOWED_PROVIDERS.contains(packageName); } }