From 9df026aa7c065a9cb6017758950964b7640f8913 Mon Sep 17 00:00:00 2001 From: cketti Date: Wed, 1 Nov 2017 18:23:59 +0100 Subject: [PATCH] Update tests in AttachmentInfoExtractorTest --- .../extractors/AttachmentInfoExtractorTest.java | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/k9mail/src/test/java/com/fsck/k9/message/extractors/AttachmentInfoExtractorTest.java b/k9mail/src/test/java/com/fsck/k9/message/extractors/AttachmentInfoExtractorTest.java index c5921c7ed9..0778c3a6c4 100644 --- a/k9mail/src/test/java/com/fsck/k9/message/extractors/AttachmentInfoExtractorTest.java +++ b/k9mail/src/test/java/com/fsck/k9/message/extractors/AttachmentInfoExtractorTest.java @@ -130,7 +130,7 @@ public class AttachmentInfoExtractorTest { } @Test - public void extractInfoForDb__withDispositionInlineAndContentId__shouldReturnInlineAttachment() + public void extractInfoForDb__withDispositionInlineAndContentIdAndMissingMimeType__shouldNotReturnInlineAttachment() throws Exception { Part part = new MimeBodyPart(); part.addRawHeader(MimeHeader.HEADER_CONTENT_ID, MimeHeader.HEADER_CONTENT_ID + ": " + TEST_CONTENT_ID); @@ -139,6 +139,20 @@ public class AttachmentInfoExtractorTest { AttachmentViewInfo attachmentViewInfo = attachmentInfoExtractor.extractAttachmentInfoForDatabase(part); + assertFalse(attachmentViewInfo.inlineAttachment); + } + + @Test + public void extractInfoForDb__withDispositionInlineAndContentIdAndImageMimeType__shouldReturnInlineAttachment() + throws Exception { + Part part = new MimeBodyPart(); + part.addRawHeader(MimeHeader.HEADER_CONTENT_TYPE, MimeHeader.HEADER_CONTENT_TYPE + ": image/png"); + part.addRawHeader(MimeHeader.HEADER_CONTENT_ID, MimeHeader.HEADER_CONTENT_ID + ": " + TEST_CONTENT_ID); + part.addRawHeader(MimeHeader.HEADER_CONTENT_DISPOSITION, MimeHeader.HEADER_CONTENT_DISPOSITION + ": " + + "inline" + ";\n filename=\"filename.ext\";\n meaningless=\"dummy\""); + + AttachmentViewInfo attachmentViewInfo = attachmentInfoExtractor.extractAttachmentInfoForDatabase(part); + assertTrue(attachmentViewInfo.inlineAttachment); } -- GitLab