Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 89fff901 authored by Rafael Tonholo's avatar Rafael Tonholo Committed by GitHub
Browse files

Merge pull request #9678 from rafaeltonholo/fix/9677/crash-secret-debug-screen 

fix(di): missing injection definition on release variant
parents bb2c5bcf a5c647a9

feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/navigation/DefaultSecretDebugSettingsNavigation.kt

0 → 100644
+25 −0
Original line number Diff line number Diff line 
package net.thunderbird.feature.debug.settings.navigation



import androidx.compose.foundation.layout.fillMaxSize

import androidx.compose.ui.Modifier

import androidx.navigation.NavGraphBuilder

import app.k9mail.core.ui.compose.navigation.deepLinkComposable

import net.thunderbird.feature.debug.settings.SecretDebugSettingsScreen

import net.thunderbird.feature.debug.settings.navigation.SecretDebugSettingsRoute.Notification



internal class DefaultSecretDebugSettingsNavigation : SecretDebugSettingsNavigation {

    override fun registerRoutes(

        navGraphBuilder: NavGraphBuilder,

        onBack: () -> Unit,

        onFinish: (SecretDebugSettingsRoute) -> Unit,

    ) {

        with(navGraphBuilder) {

            deepLinkComposable<Notification>(Notification.basePath) {

                SecretDebugSettingsScreen(

                    onNavigateBack = onBack,

                    modifier = Modifier.fillMaxSize(),

                )

            }

        }

    }

}

feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/navigation/SecretDebugSettingsNavigation.kt

+0 −26
Original line number Diff line number Diff line 
package net.thunderbird.feature.debug.settings.navigation



import androidx.compose.foundation.layout.fillMaxSize

import androidx.compose.ui.Modifier

import androidx.navigation.NavGraphBuilder

import app.k9mail.core.ui.compose.navigation.Navigation

import app.k9mail.core.ui.compose.navigation.deepLinkComposable

import net.thunderbird.feature.debug.settings.BuildConfig

import net.thunderbird.feature.debug.settings.SecretDebugSettingsScreen

import net.thunderbird.feature.debug.settings.navigation.SecretDebugSettingsRoute.Notification



interface SecretDebugSettingsNavigation : Navigation<SecretDebugSettingsRoute>
 


internal class DefaultSecretDebugSettingsNavigation : SecretDebugSettingsNavigation {

    override fun registerRoutes(

        navGraphBuilder: NavGraphBuilder,

        onBack: () -> Unit,

        onFinish: (SecretDebugSettingsRoute) -> Unit,

    ) {

        if (BuildConfig.DEBUG) {

            with(navGraphBuilder) {

                deepLinkComposable<Notification>(Notification.basePath) {

                    SecretDebugSettingsScreen(

                        onNavigateBack = onBack,

                        modifier = Modifier.fillMaxSize(),

                    )

                }

            }

        }

    }

}

feature/debug-settings/src/release/kotlin/net/thunderbird/feature/debug/settings/inject/FeatureDebugSettingsModule.kt

+3 −0
Original line number Diff line number Diff line 
package net.thunderbird.feature.debug.settings.inject



import net.thunderbird.feature.debug.settings.navigation.NoOpSecretDebugSettingsNavigation

import net.thunderbird.feature.debug.settings.navigation.SecretDebugSettingsNavigation

import org.koin.dsl.module



val featureDebugSettingsModule = module {

    single<SecretDebugSettingsNavigation> { NoOpSecretDebugSettingsNavigation }

}

feature/debug-settings/src/release/kotlin/net/thunderbird/feature/debug/settings/navigation/NoOpSecretDebugSettingsNavigation.kt

0 → 100644
+11 −0
Original line number Diff line number Diff line 
package net.thunderbird.feature.debug.settings.navigation



import androidx.navigation.NavGraphBuilder



object NoOpSecretDebugSettingsNavigation : SecretDebugSettingsNavigation {

    override fun registerRoutes(

        navGraphBuilder: NavGraphBuilder,

        onBack: () -> Unit,

        onFinish: (SecretDebugSettingsRoute) -> Unit,

    ) = Unit

}