Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 406fd6b9 authored by cketti's avatar cketti Committed by GitHub
Browse files

Merge pull request #1900 from k9mail/fix_format_string_bug

Don't use unchecked input in format string
parents acfa5d24 69344923
Loading
Loading
Loading
Loading
+7 −6
Original line number Diff line number Diff line
@@ -51,16 +51,17 @@ public class FileHelper {
        }
        // Get the extension of the file, if any.
        int index = filename.lastIndexOf('.');
        String format;
        String name;
        String extension;
        if (index != -1) {
            String name = filename.substring(0, index);
            String extension = filename.substring(index);
            format = name + "-%d" + extension;
            name = filename.substring(0, index);
            extension = filename.substring(index);
        } else {
            format = filename + "-%d";
            name = filename;
            extension = "";
        }
        for (int i = 2; i < Integer.MAX_VALUE; i++) {
            file = new File(directory, String.format(Locale.US, format, i));
            file = new File(directory, String.format(Locale.US, "%s-%d%s", name, i, extension));
            if (!file.exists()) {
                return file;
            }