update detekt baseline after cleanup (f407738e) · Commits · e / os / Find My Device

app/build.gradle.kts

+0 −11

Original line number	Diff line number	Diff line
		import io.gitlab.arturbosch.detekt.Detekt
		import io.gitlab.arturbosch.detekt.DetektCreateBaselineTask
		import org.jetbrains.kotlin.gradle.dsl.JvmTarget

		plugins {
		@@ -89,12 +87,3 @@ detekt {
		buildUponDefaultConfig = true
		autoCorrect = true
		}

		// Detekt
		tasks.withType<Detekt>().configureEach {
		jvmTarget = "25"
		}

		tasks.withType<DetektCreateBaselineTask>().configureEach {
		jvmTarget = "25"
		}

app/detekt-baseline.xml

0 → 100644

+7 −0

Original line number	Diff line number	Diff line
		<?xml version="1.0" ?>
		<SmellBaseline>
		<ManuallySuppressedIssues/>
		<CurrentIssues>
		<ID>TooGenericExceptionCaught:SmsSender.kt$SmsSender$e: Exception</ID>
		</CurrentIssues>
		</SmellBaseline>

app/src/main/java/foundation/e/findmydevice/activity/FindMyDeviceActivity.kt

+1 −3

Original line number	Diff line number	Diff line
		@@ -137,9 +137,7 @@ class FindMyDeviceActivity : FragmentActivity() {
		)
		Pages.GeneratePassword ->GenerationPasswordScreen.displayScreen(
		onBackPressed = {},
		onSelection = {
		onExitApp(true) },
		findMyDeviceActivity = this@FindMyDeviceActivity
		onSelection = { onExitApp(true) }
		)
		}
		}

app/src/main/java/foundation/e/findmydevice/receiver/SmsReceiver.kt

+1 −2

Original line number	Diff line number	Diff line
		@@ -6,9 +6,8 @@ import android.content.Intent
		import android.provider.Telephony
		import android.telephony.SmsMessage
		import android.util.Log
		import foundation.e.findmydevice.storage.PersistentStorage
		import foundation.e.findmydevice.location.LocationService
		import kotlin.collections.indexOf
		import foundation.e.findmydevice.storage.PersistentStorage

		/**
		* This component is responsible for receiving and processing incoming SMS messages.

app/src/main/java/foundation/e/findmydevice/ui/GenerationPasswordScreen.kt

+24 −33

Original line number	Diff line number	Diff line
		package foundation.e.findmydevice.ui

		import android.annotation.SuppressLint
		import android.util.Log
		import android.provider.Settings
		import androidx.activity.compose.BackHandler
		import androidx.compose.foundation.background
		import androidx.compose.foundation.border
		import androidx.compose.foundation.layout.Arrangement
		import androidx.compose.foundation.layout.Box
		import androidx.compose.foundation.layout.Column
		import androidx.compose.foundation.layout.Row
		import androidx.compose.foundation.layout.Spacer
		import androidx.compose.foundation.layout.fillMaxWidth
		import androidx.compose.foundation.layout.height
		import androidx.compose.foundation.layout.padding
		import androidx.compose.foundation.layout.Box
		import androidx.compose.foundation.layout.size
		import androidx.compose.foundation.layout.width
		import androidx.compose.foundation.rememberScrollState
		import androidx.compose.foundation.shape.RoundedCornerShape
		import androidx.compose.foundation.verticalScroll
		import androidx.compose.material3.Button
		import androidx.compose.material3.Icon
		import androidx.compose.material3.MaterialTheme
		import androidx.compose.material3.Text
		import androidx.compose.runtime.Composable
		@@ -23,43 +31,28 @@ import androidx.compose.runtime.rememberCoroutineScope
		import androidx.compose.runtime.setValue
		import androidx.compose.ui.Alignment
		import androidx.compose.ui.Modifier
		import androidx.compose.ui.draw.clip
		import androidx.compose.ui.graphics.Color
		import androidx.compose.ui.platform.LocalContext
		import androidx.compose.ui.res.colorResource
		import androidx.compose.ui.res.painterResource
		import androidx.compose.ui.res.stringResource
		import androidx.compose.ui.text.font.FontWeight
		import androidx.compose.ui.text.style.TextAlign
		import androidx.compose.ui.tooling.preview.Preview
		import androidx.compose.ui.unit.dp
		import androidx.compose.ui.unit.sp
		import foundation.e.findmydevice.util.PasswordGenerator
		import foundation.e.findmydevice.storage.PersistentStorage
		import foundation.e.findmydevice.R
		import foundation.e.findmydevice.storage.PersistentStorage
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.BOX_SIZE
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.CORNER_SIZE
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.FONT_SIZE
		import foundation.e.findmydevice.ui.buttons.actionColor
		import foundation.e.findmydevice.ui.buttons.buttonColor
		import foundation.e.findmydevice.util.Dimens
		import foundation.e.findmydevice.util.PasswordGenerator
		import kotlinx.coroutines.launch

		import android.provider.Settings
		import androidx.compose.foundation.background
		import androidx.compose.foundation.border
		import androidx.compose.foundation.rememberScrollState
		import androidx.compose.foundation.verticalScroll
		import androidx.compose.foundation.layout.size
		import androidx.compose.foundation.layout.width
		import androidx.compose.foundation.shape.RoundedCornerShape
		import androidx.compose.material3.Icon
		import androidx.compose.ui.draw.clip
		import androidx.compose.ui.res.colorResource
		import androidx.compose.ui.res.painterResource
		import androidx.core.content.ContextCompat
		import foundation.e.findmydevice.activity.FindMyDeviceActivity
		import foundation.e.findmydevice.activity.FindMyDeviceActivity.Companion.TAG
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.BOX_SIZE
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.CORNER_SIZE
		import foundation.e.findmydevice.ui.GenerationPasswordScreen.FONT_SIZE
		import kotlinx.coroutines.suspendCancellableCoroutine
		import kotlin.coroutines.resume

		/**
		* GenerationPasswordScreen
		*
		@@ -80,11 +73,10 @@ object GenerationPasswordScreen {
		@Composable
		fun displayScreen(
		onBackPressed: () -> Unit,
		onSelection: () -> Unit,
		findMyDeviceActivity: FindMyDeviceActivity?
		onSelection: () -> Unit
		) {
		BackHandler(onBack = { onBackPressed() })
		generatePasswordScreenContent(onSelection, findMyDeviceActivity)
		generatePasswordScreenContent(onSelection)
		}
		}

		@@ -92,13 +84,12 @@ object GenerationPasswordScreen {
		@SuppressLint("ComposableNaming")
		@Composable
		fun generatePasswordScreenPreview() {
		generatePasswordScreenContent(onSelection = {}, findMyDeviceActivity = null)
		generatePasswordScreenContent(onSelection = {})
		}

		@SuppressLint("ComposableNaming")
		@Composable
		fun generatePasswordScreenContent(onSelection: () -> Unit,
		findMyDeviceActivity: FindMyDeviceActivity? = null) {
		fun generatePasswordScreenContent(onSelection: () -> Unit) {
		val context = LocalContext.current
		val persistentStorage = PersistentStorage(context)
		val scope = rememberCoroutineScope()
		@@ -176,7 +167,7 @@ fun generatePasswordScreenContent(onSelection: () -> Unit,
		}

		@Composable
		fun setNewCode(findMyDeviceActivity: FindMyDeviceActivity) {
		fun setNewCode() {
		val contentResolver = context.getContentResolver()
		val isProvisioned = Settings.Global.getInt(
		contentResolver,
		@@ -303,7 +294,7 @@ fun generatePasswordScreenContent(onSelection: () -> Unit,

		Spacer(modifier = Modifier.height(Dimens.TEXT_SPACING))

		setNewCode(findMyDeviceActivity = findMyDeviceActivity!!)
		setNewCode()

		Spacer(modifier = Modifier.height(Dimens.TEXT_SPACING))